Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing code for merge_substates in "Using the Framework" RTD #142

Closed
charleswhchan opened this issue May 12, 2019 · 4 comments · Fixed by #260
Closed

Missing code for merge_substates in "Using the Framework" RTD #142

charleswhchan opened this issue May 12, 2019 · 4 comments · Fixed by #260
Labels
bug Something isn't working

Comments

@charleswhchan
Copy link

Reading along the examples provided in "Using the Framework", it is not apparent where merge_substates is defined.

Do we need to include def merge_substates() in the document from the following file?
https://github.com/dwavesystems/dwave-hybrid/blob/2614c00c07a6bc867292f66e19b73f9e453c8d37/examples/qbsolv-like-alt.py

@randomir
Copy link
Member

Yes. I think we should, for now, just include the merge_substates' code in the docs, @JoelPasvolsky. That is, until (or if) we create a top-level block for hstack-ing of subsamples.

@JoelPasvolsky
Copy link
Contributor

@randomir, I'd want to move def merge_substates(_, substates): from its current location to utils.py before getting it picked up by utilities.rst. TBH it seems to belong more to primitive methods but you have your two stacking functions there like a mama and papa waiting to reunite with baby merge_substates. What do you think?

@randomir
Copy link
Member

As it is, merge_substates from the qbsolv-like example is too specific -- it is more of an example of Reduce/Lambda use than anything else.

We could/should create all {hstack, vstack} x {samples, subsamples} block variants - probably under hybrid.composers. Right now, we only have "vstack of samples" available as hybrid.composers.MergeSamples.

@JoelPasvolsky
Copy link
Contributor

Should we talk about this next week, see how to best schedule all the work for what we currently have and what we'll like have in two months?

@randomir randomir added the bug Something isn't working label Jun 28, 2019
randomir added a commit to randomir/dwave-hybrid that referenced this issue Dec 13, 2021
randomir added a commit that referenced this issue Dec 13, 2021
* Clarify/expand code of "Flow refining" docs

Close #142.

* Fix docs ref
randomir added a commit to randomir/dwave-hybrid that referenced this issue Dec 21, 2021
New Features
---

- Add `hybrid.Log`, a block to log user-define state metrics to a JSON
  file, python logger, or in-memory queue or list. See dwavesystems#257.

- Add convenience JSON encoders for commonly used NumPy
  (`hybrid.utils.NumpyEncoder`) and Ocean types
(`hybrid.utils.OceanEncoder`). See dwavesystems#257.

Fixes
---

- Clarify docs, dwavesystems#142.

Upgrade
---

- Drop dimod 0.8.x support. Oldest supported dimod version is now 0.9.6.
  See dwavesystems#259.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants