Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/cb2-12323: Fix the local development with serverless #183

Merged
merged 3 commits into from
Sep 30, 2024
Merged

feature/cb2-12323: Fix the local development with serverless #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66472bf
added debug event and scripts
me-matt Sep 5, 2024
bf2d003
updated lock file
me-matt Sep 12, 2024
a404335
updated app config serverless desscription
me-matt Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Debug NPM Script",
"runtimeExecutable": "npm",
"runtimeArgs": [
"run",
"start:debug"
],
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen",
"skipFiles": ["<node_internals>/**"]
}
]
}
4 changes: 4 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
{
"testing.openTesting": "neverOpen",
"search.exclude": {
"**/node_modules": false
}
}
6 changes: 6 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,9 @@ services:
ports:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. instead of wait hosts might be better do to a health check to ensure that it's able to accept the connectio n and not just booted up.
  2. Might as well update the version whule we're here
  3. why not use the aws infromation
  4. wonder if it's worth making the volumes read only and also adding an additional one a named volume for persistence
  5. no network? might be worth adding one for insolation purposes
  6. coould add the image service running type ie node:20 etc.
  7. I also presume that this is going to be dependant on the s3 and sqs now starting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I agree with what you've said, I'm also keen to make these changes minimal and related to the particular ticket.

The local development needs a bit of an overhaul, but for the purposes of getting serverless running and enabling debug feature in code we're really just missing the sqs container.

Happy if we add more tickets after all the cert gen changes are merged in? (otherwise it would likely mean changing things here, then again later anyway).

- "7000:7000" # s3 server
- "9991:9991" # data store
sqs:
container_name: sqs
image: softwaremill/elasticmq
ports:
- "9324:9324"
- "9325:9325"
Loading
Loading