-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/cb2-12323: Fix the local development with serverless #183
Conversation
e54a5e2
to
be66d89
Compare
@@ -18,3 +18,9 @@ services: | |||
ports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- instead of wait hosts might be better do to a health check to ensure that it's able to accept the connectio n and not just booted up.
- Might as well update the version whule we're here
- why not use the aws infromation
- wonder if it's worth making the volumes read only and also adding an additional one a named volume for persistence
- no network? might be worth adding one for insolation purposes
- coould add the image service running type ie node:20 etc.
- I also presume that this is going to be dependant on the s3 and sqs now starting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I agree with what you've said, I'm also keen to make these changes minimal and related to the particular ticket.
The local development needs a bit of an overhaul, but for the purposes of getting serverless running and enabling debug feature in code we're really just missing the sqs container.
Happy if we add more tickets after all the cert gen changes are merged in? (otherwise it would likely mean changing things here, then again later anyway).
@@ -14,19 +14,24 @@ provider: | |||
- "xray:PutTelemetryRecords" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- dont you need to allow the s3 put get objects here in the iam section, same for the sqs on the recieve, delete etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't made any changes so it's whatever was there before. Though agreed, the serverless setup needs a proper review.
This PR just lets us utilise the debug features in vscode.
serverless.yml
Outdated
Type: AWS::AppConfig::Application | ||
Properties: | ||
Name: "cvs-app-config" | ||
Description: "Example serverless feature flag demo." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change the desc pls
78da00d
to
ddb1442
Compare
ddb1442
to
a404335
Compare
Fix local development
Fixes the serverless configuration to do local debugging.
Note: This branch is based on the linting changes here #182.
Fix local development
Checklist
id
required prepended with"test-"
have been checked with automation testers and added