Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/cb2-12323: Fix the local development with serverless #183

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

me-matt
Copy link
Contributor

@me-matt me-matt commented Sep 9, 2024

Fix local development

Fixes the serverless configuration to do local debugging.

Note: This branch is based on the linting changes here #182.

Fix local development

Checklist

  • Branch is rebased against the latest develop/common
  • Necessary id required prepended with "test-" have been checked with automation testers and added
  • Code and UI has been tested manually after the additional changes
  • PR title includes the JIRA ticket number
  • Squashed commits contain the JIRA ticket number
  • Link to the PR added to the repo
  • Delete branch after merge

@@ -18,3 +18,9 @@ services:
ports:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. instead of wait hosts might be better do to a health check to ensure that it's able to accept the connectio n and not just booted up.
  2. Might as well update the version whule we're here
  3. why not use the aws infromation
  4. wonder if it's worth making the volumes read only and also adding an additional one a named volume for persistence
  5. no network? might be worth adding one for insolation purposes
  6. coould add the image service running type ie node:20 etc.
  7. I also presume that this is going to be dependant on the s3 and sqs now starting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I agree with what you've said, I'm also keen to make these changes minimal and related to the particular ticket.

The local development needs a bit of an overhaul, but for the purposes of getting serverless running and enabling debug feature in code we're really just missing the sqs container.

Happy if we add more tickets after all the cert gen changes are merged in? (otherwise it would likely mean changing things here, then again later anyway).

@@ -14,19 +14,24 @@ provider:
- "xray:PutTelemetryRecords"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. dont you need to allow the s3 put get objects here in the iam section, same for the sqs on the recieve, delete etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't made any changes so it's whatever was there before. Though agreed, the serverless setup needs a proper review.

This PR just lets us utilise the debug features in vscode.

serverless.yml Outdated
Type: AWS::AppConfig::Application
Properties:
Name: "cvs-app-config"
Description: "Example serverless feature flag demo."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change the desc pls

naathanbrown
naathanbrown previously approved these changes Sep 25, 2024
cb-cs
cb-cs previously approved these changes Sep 26, 2024
@me-matt me-matt merged commit 2e417ba into develop Sep 30, 2024
7 checks passed
@me-matt me-matt deleted the feature/cb2-12323 branch September 30, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants