Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2560 Fire GridStat use case #2769

Merged
merged 27 commits into from
Nov 13, 2024
Merged

Feature #2560 Fire GridStat use case #2769

merged 27 commits into from
Nov 13, 2024

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Nov 5, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

Confirmed use case runs successfully in automated test environment

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

New fire use case will require update of truth data set

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 11/8/2024.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…o the valid time. Assuming that the files are in order, it will use the first file if multiple files match the valid hour or the last file if multiple files match 1 hour prior to the valid hour. This does not factor in if files before and after the valid time were found. Modifications are needed to obtain the correct file if, for example, the valid time is 12Z and there are 1258 and 1159 files available -- in this case the 1258 file will be used even though 1159 is closer.
@georgemccabe georgemccabe added this to the METplus-6.0.0 milestone Nov 5, 2024
@georgemccabe georgemccabe linked an issue Nov 5, 2024 that may be closed by this pull request
24 tasks
@georgemccabe georgemccabe requested a review from j-opatz November 5, 2024 16:28
@georgemccabe georgemccabe marked this pull request as ready for review November 7, 2024 20:54
Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New use case conforms to template guidance, adds in new quick search options. Automated testing errors are expected (missing truth data for this use case).

@georgemccabe georgemccabe merged commit b4c52c2 into develop Nov 13, 2024
67 of 69 checks passed
georgemccabe pushed a commit that referenced this pull request Nov 13, 2024
removing notes to avoid failure in GHA printing GITHUB CONTEXT
@georgemccabe georgemccabe deleted the feature_2560_fire branch December 17, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

New Use Case: Fire Weather
2 participants