Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Use Case: Fire Weather #2560

Closed
24 tasks
georgemccabe opened this issue Apr 23, 2024 · 0 comments · Fixed by #2769
Closed
24 tasks

New Use Case: Fire Weather #2560

georgemccabe opened this issue Apr 23, 2024 · 0 comments · Fixed by #2769
Assignees
@georgemccabe
Labels
priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: new use case Add a new use case
Milestone
METplus-6.0.0

Comments

@georgemccabe
Copy link
Collaborator

This use case was demonstrated as part of the METplus Advanced Training Series in November 2023, but the use case was not added to the repository.

Describe the New Use Case

Provide a description of the new feature request here.

Use Case Name and Category

short_range

Input Data

List input data types and sources.
Provide a total input file size, keeping necessary data to a minimum.

Acceptance Testing

Describe tests required for new functionality.
As use case develops, provide a run time here

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

7750062

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)
  • Select privacy

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Use Case Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept your changes. Merge branch into develop.
  • Create a second pull request to merge develop into develop-ref, following the same steps for the first pull request.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: new use case Add a new use case labels Apr 23, 2024
@georgemccabe georgemccabe added this to the METplus-6.0.0 milestone Apr 23, 2024
@georgemccabe georgemccabe moved this from 🔖 Ready to 🏗 In progress in METplus-Wrappers-6.0.0 Development Apr 23, 2024
georgemccabe added a commit that referenced this issue May 8, 2024
@georgemccabe
per #2560, add new use case to automated tests
9c3b148
@georgemccabe georgemccabe linked a pull request Nov 5, 2024 that will close this issue
Feature #2560 Fire GridStat use case #2769
Merged
16 tasks
@georgemccabe georgemccabe moved this from 🏗 In progress to 🔎 In review in METplus-Wrappers-6.0.0 Development Nov 5, 2024
georgemccabe added a commit that referenced this issue Nov 13, 2024
@georgemccabe @j-opatz
Feature #2560 Fire GridStat use case (#2769)
b4c52c2 
* added config file and python scripts for fire weather use case

* Improved logic if multiple files were found to use the closest file to the valid time. Assuming that the files are in order, it will use the first file if multiple files match the valid hour or the last file if multiple files match 1 hour prior to the valid hour. This does not factor in if files before and after the valid time were found. Modifications are needed to obtain the correct file if, for example, the valid time is 12Z and there are 1258 and 1159 files available -- in this case the 1258 file will be used even though 1159 is closer.

* rename use case and update configuration to read data from appropriate directories

* per #2560, add new use case to automated tests

* turn of use case to prepare for PR

* removed comments

* added in-progress use case documentation - still needs updates

* fix formatting

* more formatting

* more doc formatting and cleanup

* remove notes from sections that were updated

* doc cleanup

* add thumbnail for new use case

* add description of fire use case category

* turn off use case

* fix SonarQube complaints

* update use case doc to match use case template

* minor formatting change to match template

* update path for kml schema file

* use wildcard to avoid having to reference namespace that includes insecure protocol

* Update documentation to resemble template

---------

Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-Wrappers-6.0.0 Development Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgemccabe georgemccabe

Labels
priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: new use case Add a new use case
Projects
No open projects
METplus-Wrappers-6.0.0 Development
Status: 🏁 Done
Milestone
METplus-6.0.0
Development

Successfully merging a pull request may close this issue.

Feature #2560 Fire GridStat use case dtcenter/METplus
3 participants
@TaraJensen @georgemccabe @j-opatz