Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor series by lead animation logic #336

Closed
bikegeek opened this issue Dec 10, 2019 · 1 comment
Closed

Refactor series by lead animation logic #336

bikegeek opened this issue Dec 10, 2019 · 1 comment
Labels
component: python wrapper priority: medium Medium Priority requestor: NCAR National Center for Atmospheric Research

Comments

@bikegeek
Copy link
Contributor

Extracting the 'TODO' in the create_animated_gifs() method in series_by_lead_wrapper.py (as added by Jim Frimel):
# TODO:
# Fix animate_cmd so it does not require run_inshell
# to work.
# It is working as is, ideally we do not require
# run_inshell
# The issue has to do with multiple files in the directory
# when using the wild card. If only one file exists
# then the command will run ok without run_inshell.
# You can repeat the issue
# by removing run_inshell keyword in the call below and
# running examples/custom_series_by_lead_all_fhrs.conf use case.
# no animated gifs are created.
# convert: unable to open image
# .... No such file or directory
# @ error/blob.c/OpenBlob/2712.
# convert: unable to open file
# convert: no images defined

@bikegeek bikegeek added this to the METplus Future Versions milestone Dec 10, 2019
bikegeek added a commit that referenced this issue Dec 10, 2019
…rectory and create a fresh tmp directory after removing it so there is a tmp directory ready for a re-run or the next wrapper. Removed 'TODO' comment and created a new Github issue: #336.
@georgemccabe
Copy link
Collaborator

This was completed with work for #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: python wrapper priority: medium Medium Priority requestor: NCAR National Center for Atmospheric Research
Projects
None yet
Development

No branches or pull requests

3 participants