Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor series_by_lead wrapper #332

Closed
bikegeek opened this issue Dec 2, 2019 · 1 comment
Closed

Refactor series_by_lead wrapper #332

bikegeek opened this issue Dec 2, 2019 · 1 comment
Assignees

Comments

@bikegeek
Copy link
Contributor

bikegeek commented Dec 2, 2019

Refactor the series by lead wrapper to stop depending on a process id to identify a particular series by lead run. It was originally assumed that the tc-pairs wrapper, extract tiles wrapper and series by init wrappers would be run in succession to satisfy the origin use case/funding institution, as such, it was necessary to identify which groups of wrappers were associated. This dependence on identifying which output/input combinations via a process id makes it impossible to create a unit test for the series by lead wrapper. Currently, only a system test (where the series by lead wrapper is run after the tc pairs and extract tiles wrappers have been run) can be created, which checks the final output.

@bikegeek bikegeek added this to the METplus Future Versions milestone Dec 2, 2019
@bikegeek bikegeek self-assigned this Dec 5, 2019
bikegeek added a commit that referenced this issue Dec 10, 2019
…rectory and create a fresh tmp directory after removing it so there is a tmp directory ready for a re-run or the next wrapper. Removed 'TODO' comment and created a new Github issue: #336.
@bikegeek
Copy link
Contributor Author

Merged updates to 'develop' branch. No longer create a subdir in the tmp directory based on the process id and after removing tmp dir, create a new, empty tmp dir so it is available if series by lead wrapper or another wrapper is to be run again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant