Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct GitHub Pull Request Template - Fixes #520 #521

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Correct GitHub Pull Request Template - Fixes #520 #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
Change to [x] for each task in the task list that applies to your PR.
For those task that don't apply to you PR, leave those as is.
-->

- [ ] Added an entry under the Unreleased section of the change log in
CHANGELOG.md. Entry should say what was changed, and how that affects
users (if applicable).
Expand All @@ -48,6 +49,4 @@
- [ ] Integration tests added/updated (where possible). See
[DSC Resource Testing Guidelines](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [ ] New/changed code adheres to
[DSC Resource Style Guidelines](https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)
and
[Best Practices](https://github.com/PowerShell/DscResources/blob/master/BestPractices.md).
[DSC Resource Style Guidelines and Best Practices](https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@

## Unreleased

- Corrected GitHub Pull Request template to remove referral to
`BestPractices.MD` which has been combined into `StyleGuidelines.md`
([issue #520](https://github.com/PowerShell/xPSDesiredStateConfiguration/issues/520)).
- xWindowsOptionalFeature
- Suppress useless verbose output from `Import-Module` cmdlet.
([issue 453](https://github.com/PowerShell/xPSDesiredStateConfiguration/issues/453))
([issue #453](https://github.com/PowerShell/xPSDesiredStateConfiguration/issues/453)).
- Changes to xRemoteFile
- Corrected a resource name in the example xRemoteFile_DownloadFileConfig.ps1
- Fix `MSFT_xDSCWebService` to find
Expand Down