Correct GitHub Pull Request Template - Fixes #520 #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #521 +/- ##
===================================
Coverage 74% 74%
===================================
Files 27 27
Lines 4031 4031
Branches 4 4
===================================
Hits 3005 3005
Misses 1022 1022
Partials 4 4 |
mhendric
approved these changes
Feb 3, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Looks good to me @PlagueHO . Just needs a rebase and we're good to merge. |
mhendric
added
waiting for author response
|
Should be good to go now @mhendric |
mhendric
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR removes the reference to the deprecated BestPractices.MD document from the GitHub PR template.
Also corrects one of the minor markdown violations in it.
This Pull Request (PR) fixes the following issues
Task list
CHANGELOG.md. Entry should say what was changed, and how that affects
users (if applicable).
and comment-based help.
appropriate.
DSC Resource Testing Guidelines.
DSC Resource Testing Guidelines.
DSC Resource Style Guidelines
and
Best Practices.
This change is