Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xService: Description should allow empty string #181

Closed
bswerdlen opened this issue Jul 18, 2016 · 0 comments · Fixed by #186
Closed

xService: Description should allow empty string #181

bswerdlen opened this issue Jul 18, 2016 · 0 comments · Fixed by #186
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@bswerdlen
Copy link

If a service does not have a Description, test and set DSC resource functions both fail even though Description is not a required parameter. Please allow the Description to be an empty string.

Recommend changing the parameter
[System.String]
[ValidateNotNullOrEmpty()]
$Description

to
[System.String]
[ValidateNotNull()]
$Description
@kwirkykat kwirkykat added the enhancement The issue is an enhancement request. label Jul 21, 2016
@kwirkykat kwirkykat changed the title xService requires a description xService: Description should allow empty string Jul 21, 2016
@kwirkykat kwirkykat added help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jul 21, 2016
This was referenced Aug 2, 2016
Merged
Merged
kwirkykat added a commit that referenced this issue Aug 2, 2016
@kwirkykat
Merge pull request #186 from Dan1el42/issue-181
fe90627 
Change parameter validation of Description to ValidateNotNull. Resolves #181.
@vors vors removed the help wanted The issue is up for grabs for anyone in the community. label Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
3 participants
@vors @kwirkykat @bswerdlen