Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid parameters for sample of xArchive resource. Resolves #179. #185

Merged
merged 3 commits into from
Aug 2, 2016

Conversation

Dan1el42
Copy link
Contributor

@Dan1el42 Dan1el42 commented Aug 2, 2016

Taking a stab at resolving #179. AppVeyor build is passing on my fork.

Cheers
Daniel


This change is Reviewable

Daniel Krebs added 3 commits August 2, 2016 09:04
The parameters CompressionLevel, DestinationType and MatchSource are not valid and need to be removed for the example to work.
The parameters CompressionLevel and MatchSource are not valid for this resource and should be removed to avoid confusion.
The xArchive resource does not support the extraction of multiple files into the same destination.
@Dan1el42 Dan1el42 changed the title Change parameter validation of Description to ValidateNotNull. Resolves #181. Change parameter validation of Description to ValidateNotNull. Resolves #179. Aug 2, 2016
@Dan1el42 Dan1el42 changed the title Change parameter validation of Description to ValidateNotNull. Resolves #179. Remove invalid parameters for sample of xArchive resource. Resolves #179. Aug 2, 2016
@kwirkykat
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@kwirkykat kwirkykat merged commit c210c99 into dsccommunity:dev Aug 2, 2016
@Dan1el42 Dan1el42 deleted the issue-179 branch August 3, 2016 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants