-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xWebsite - Implemented support for non-HTTP bindings #69
Conversation
SNikalaichyk
commented
Dec 11, 2015
- Implemented support for the following binding protocols: "msmq.formatname", "net.msmq", "net.pipe", "net.tcp".
- Implemented support for setting the "EnabledProtocols" property.
- Test-* functions updated to return $true if the tested object is valid, is in the desired state, and does not require modification.
- The module was redesigned and refactored.
- Unit tests updated.
- Implemented support for the following binding protocols: "msmq.formatname", "net.msmq", "net.pipe", "net.tcp". - Implemented support for setting the "EnabledProtocols" property. - Test-* functions updated to return $true if the tested object is valid, is in the desired state, and does not require modification. - The module was redesigned and refactored. - Unit tests updated.
Hi @SNikalaichyk, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
@@ -110,6 +118,7 @@ function Set-TargetResource | |||
[String] | |||
$State = 'Started', | |||
|
|||
[ValidateLength(1, 64)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help me understand this change and what we're hoping to acomplish?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The application pool name must contain between 1 and 64 characters.
Further refactoring
[Required] String PhysicalPath; | ||
[Write,ValueMap{"Started","Stopped"},Values{"Started", "Stopped"}] String State; | ||
[Write] String ApplicationPool; | ||
[Write, EmbeddedInstance("MSFT_xWebBindingInformation"), Description("Hashtable containing binding information")] String BindingInfo[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a hash table, but instead an array of embedded instances. The description should be improved.
Add-windowsfeature should not be needed for unit test, and is not included in the current unit test suite. Please merge with the latest code. |
CIM class versions fixed. Test script updated to use the up-to-date template.
MSFT_xWebsite.Tests.ps1 was ignored by mistake. Removed.
Hi @TravisEz13, |
MSFT_xWebsite.psm1 line 866-869 catch
{
throw $_.Exception.Message
} You should throw the exception, not the message. |
MSFT_xWebsite.psm1 - General Write-Verbose -Message ( @( "$($MyInvocation.MyCommand): "
$($LocalizedData.Key) -f $Parameter
) -join '') When we eventually get around to PRs that do translation of the strings we can reference the right things. MSFT_xWebsite.psm1 - Line - 51/140 MSFT_xWebsite.psm1 - Line 94 MSFT_xWebsite.psm1 - Line 344 MSFT_xWebsite.psm1 - Line 530 MSFT_xWebsite.psm1 - Line 946/947 MSFT_xWebsite.psm1 - Line 689 |
- Verbose messages moved to LocalizedData. - Updated to use helper module
All of your requirements have been implemented.
I allow null and empty strings to be passed to the Format-IPAddressString and Test-PortNumber helper functions, not disallow.
Yes, it is possible to add identical non-standard bindings (such as "net.tcp") to different sites. |
Please include a summary of changes in an unreleased version change per the contribution guidelines |
* Test scripts updated to use the latest templates. * README updated.
Can you please re-run AppVeyor build? For some reason it timed out during the last commit. |
I triggered a rerun in AppVeyor. It hasn't started yet. |
LGTM. Thanks @SNikalaichyk |
xWebsite - Implemented support for non-HTTP bindings