Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: xWebApplication.EnabledProtocols #145

Closed
rs38 opened this issue Jun 7, 2016 · 9 comments
Closed

feature request: xWebApplication.EnabledProtocols #145

rs38 opened this issue Jun 7, 2016 · 9 comments
Labels
enhancement The issue is an enhancement request.

Comments

@rs38
Copy link

rs38 commented Jun 7, 2016

it was already included on website level (see this Pullreq. xWebsite - Implemented support for non-HTTP bindings) for xWebSite.EnabledProtocols, but still missing on application level, like xWebApplication.EnabledProtocols='net.tcp'

It would be possible implicitly by sth. like Site.ApplicationDefaults Property, but that is also not implemented.

@rs38
Copy link
Author

rs38 commented Jun 7, 2016

without DSC it's done like this:

Note: enabledProtocols seems to be case sensitive!

Set-ItemProperty "IIS:\Sites\Default Web Site\MyWebApp1" -name enabledProtocols -Value 'net.tcp'

and the mentioned AppDefaults:
Set-ItemProperty "IIS:\Sites\Default Web Site" -name applicationDefaults.enabledProtocols -Value 'net.tcp'

I would like to include it in a PR but I doubt I will be able to satisfy you quality standards with testing and pester in the moment

@nzspambot
Copy link

@rs38 I have code to do this; can add it soonish to help you out if you would like

@rs38
Copy link
Author

rs38 commented Jun 15, 2016

@nzspambot yes, that would be nice!
How about a generic DSC XWebsite Resource that can configure an arbitrary part of the IIS like
Set-ItemProperty "IIS:\Sites\XYZ" -name XYTProperty -Value 'XYZValue'?

or did I miss it?

@nzspambot
Copy link

Yep that is it, IIRC it is a string input so will need to do some -join on a validate set since IIRC we can only have net.tcp, net.msmq, http and https (that is off the top of my head BTW so could be wrong)

@nzspambot
Copy link

I haven't forgotten about this @rs38 ; about to start this right now so standby 🙏

@nzspambot
Copy link

@rs38 track that PR ☝️

@rs38
Copy link
Author

rs38 commented Jun 26, 2016

@nzspambot appreciate it!

@kwirkykat kwirkykat added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Aug 19, 2016
@nzspambot
Copy link

@rs38 this is now in the Dev branch

Feel free to close this now ( @mbreakey3 )

@tysonjhayes
Copy link

Thanks for following up!

@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Development

No branches or pull requests

5 participants