Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BREAKING CHANGE to CHANGELOG.MD - Fixes #171 #194

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Oct 11, 2018

Pull Request (PR) description

This PR adds the BREAKING CHANGE information to the CHANGELOG.MD that got missed when submitting PR #193.

This Pull Request (PR) fixes the following issues

Fixes #171

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing?


This change is Reviewable

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov-io
Copy link

Codecov Report

Merging #194 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #194   +/-   ##
==================================
  Coverage   90%    90%           
==================================
  Files        7      7           
  Lines      735    735           
==================================
  Hits       667    667           
  Misses      68     68

@PlagueHO PlagueHO merged commit d7679dc into dsccommunity:dev Oct 11, 2018
@PlagueHO PlagueHO deleted the Issue-171-Fix branch October 11, 2018 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PowerPlan: Add a read-only property IsActive
3 participants