Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerPlan: Add a read-only property IsActive #171

Closed
johlju opened this issue Jul 20, 2018 · 0 comments · Fixed by #193 or #194
Closed

PowerPlan: Add a read-only property IsActive #171

johlju opened this issue Jul 20, 2018 · 0 comments · Fixed by #193 or #194
Assignees
@PlagueHO
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jul 20, 2018 •
edited
Loading

Details of the scenario you tried and the problem that is occurring:
Suggest we add a read-only property IsActive to the resource PowerPlan, and set that to $plan.isActive instead of setting the $Name to $null in Get-TargetResource if the plan is not the active plan.

https://github.com/PowerShell/ComputerManagementDsc/blob/c0a60754c2ec537f1668e4a3cf6ca7423a8c9a2c/Modules/ComputerManagementDsc/DSCResources/MSFT_PowerPlan/MSFT_PowerPlan.psm1#L67-L76

The DSC configuration that is using the resource (as detailed as possible):
Any configuration that hasn't the power plan as the active power plan.

Version of the Operating System and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju changed the title PowerPlan: Add a red-only property IsActive PowerPlan: Add a read-only property IsActive Jul 20, 2018
@PlagueHO PlagueHO added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jul 24, 2018
@TraGicCode TraGicCode mentioned this issue Oct 3, 2018
Merged
9 tasks
PlagueHO added a commit that referenced this issue Oct 11, 2018
@PlagueHO
Merge pull request #193 from TraGicCode/GH-171-add-is-active-read-onl…
99c25ff 
…y-property

BREAKING CHANGE: PowerPlan: Add IsActive read-only property
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Oct 11, 2018
@PlagueHO PlagueHO mentioned this issue Oct 11, 2018
Merged
9 tasks
PlagueHO added a commit that referenced this issue Oct 11, 2018
@PlagueHO
Merge pull request #194 from PlagueHO/Issue-171-Fix
d7679dc 
Add BREAKING CHANGE to CHANGELOG.MD - Fixes #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PlagueHO PlagueHO

Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
2 participants
@johlju @PlagueHO