Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options page #69

Merged
merged 17 commits into from
Mar 15, 2014
Merged

Options page #69

merged 17 commits into from
Mar 15, 2014

Conversation

h0ru5
Copy link
Collaborator

@h0ru5 h0ru5 commented Mar 14, 2014

Ongoing work!
First protoype functions are working.

@j6k4m8 and me will merge our stuff here and post a comment

@h0ru5 h0ru5 mentioned this pull request Mar 14, 2014
…page

reverted to option that are already adhered in the main script
@h0ru5
Copy link
Collaborator Author

h0ru5 commented Mar 14, 2014

UI is using the boilerplate, options can now be added in the markup, I'll continue with the other options already in the script.

I am not yet clear how to do the fonts...

@nomicode
Copy link
Contributor

Here's the UI for Draft:

screen shot 2014-03-15 at 11 56 15

I love the simplicity of this. Those are regular text boxes. No auto-complete, nothing fancy. You just type what you want to type. The app assumes you know what to do.

@j6k4m8
Copy link
Contributor

j6k4m8 commented Mar 15, 2014

I like that (and I love Draft). I'm more than happy to adopt something similar.

@h0ru5
Copy link
Collaborator Author

h0ru5 commented Mar 15, 2014

I took the richer widget approach for the fonts (the <select> is filled with all installed fonts), but might use the all-textfields for the rest to get the tires on the road...

@nomicode
Copy link
Contributor

What's the advantage of using select over an text input field?

@h0ru5
Copy link
Collaborator Author

h0ru5 commented Mar 15, 2014

@nslater that you can choose of the installed fonts and don't have to type in the name. Its more friendly for casual users. To be usable for people that don't know css, we cannot simply have a text field.

If somebody wants to turn the select into a combo box, I'll gladly merge it in and we could have both approaches combined.

@nomicode
Copy link
Contributor

Fair enough!

@h0ru5
Copy link
Collaborator Author

h0ru5 commented Mar 15, 2014

@ds300 Ok, all options that exist in the options object are now also in the page and @j6k4m8 added a possibility to have a custom font.

@ds300
Copy link
Owner

ds300 commented Mar 15, 2014

Does that mean I'm good to merge?

@h0ru5
Copy link
Collaborator Author

h0ru5 commented Mar 15, 2014

'yes please' 👍

@ds300
Copy link
Owner

ds300 commented Mar 15, 2014

Hooray!

ds300 added a commit that referenced this pull request Mar 15, 2014
@ds300 ds300 merged commit 441dba5 into ds300:dev Mar 15, 2014
@ds300
Copy link
Owner

ds300 commented Mar 15, 2014

I just tried this out for the first time. Seriously awesome work guys! Well done :)

@nomicode
Copy link
Contributor

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants