Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt-s problematic with some keyboard setups #9

Open
CorvusEtiam opened this issue Mar 7, 2014 · 7 comments
Open

Alt-s problematic with some keyboard setups #9

CorvusEtiam opened this issue Mar 7, 2014 · 7 comments

Comments

@CorvusEtiam
Copy link

Jetzt is great extension, but to use it without problems with my current setup (Polish keyboard) I had to change default keybinding to Alt+j
on this line.

if (!instructions && ev.altKey && ev.keyCode === 83) {
// more code
}

It would be great if can change the default keybinding without editing source code.
If you don't mind about it, I can even write something like that.

@ds300
Copy link
Owner

ds300 commented Mar 7, 2014

An options page where you can set keybindings and so forth would be most welcome, and definitely a requirement for a published version of jetzt. Before that happens I want to separate out the core jetzt functionality into it's own file and write a cleaner config abstraction. I'll comment here when that's done (some time this weekend probably) and if you still want to have a go at writing a page to set keybindings, that'd be awesome.

@h0ru5
Copy link
Collaborator

h0ru5 commented Mar 8, 2014

#21 offers at least a workaround by clicking an icon, it would also be a good place to hook up a config page

@ds300
Copy link
Owner

ds300 commented Mar 9, 2014

@Demagogue: The code is now in a state where this can be done. Also many thanks to @h0ru5 for hooking up the browser action!

@BlueDrink9
Copy link

Did any progress get made here? I see it mentioned under #69 in the TODO section, but keybindings apparently remain uncustomisable.

@ds300
Copy link
Owner

ds300 commented May 3, 2018

Hi! 👋 looks like it's not configurable but you can edit the code at this line:

if (!jetzt.isOpen() && ev.altKey && ev.keyCode === 83) {
to choose which key combination should launch jeztz

@BlueDrink9
Copy link

Thank you, that was the documentation I was after. I noticed a couple of other places similar code appeared, like in jetzt-solid.min.js and jetzt.js (lines 4 and 2, but they're huge). Will that affect anything?

@ds300
Copy link
Owner

ds300 commented May 3, 2018

hmm probably. I expect you'll need to rebuild the project with 'npm start' after changing the above line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants