-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS support, support for more apps, measures for ensuring production and experimentation modes #17
Merged
Commits on Sep 24, 2020
-
Support for more apps on Android
Support for several apps added including verification of end-to-end working. Apps found by searching for "BHIM" and "UPI" on play store and app store and also from these links: https://www.upichalega.com/upi-partners.php https://www.npci.org.in/upi-PSP&3rdpartyApps https://www.npci.org.in/upi-live-members https://www.sebi.gov.in/sebiweb/other/OtherAction.do?doRecognisedFpi=yes&intmId=43
Configuration menu - View commit details
-
Copy full SHA for 320430e - Browse repository at this point
Copy the full SHA 320430eView commit details
Commits on Sep 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4df11a8 - Browse repository at this point
Copy the full SHA 4df11a8View commit details
Commits on Apr 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5a77f18 - Browse repository at this point
Copy the full SHA 5a77f18View commit details
Commits on Apr 21, 2021
-
iOS Support - iOS method channel providing canLaunch and launch methods towards discovering UPI apps and launching them respectively. - Added the custom schemes of the iOS apps in the example app's Info.plist to make iOS payment work in the example app. - Changed the example app to show different views for Android and iOS. Android view is same as before. iOS view clearly shows that none of the apps can be picked by the user, as on iOS they are picked by iOS against the upi://pay? calls made to make the UPI transaction. The iOS view also shows that some of the apps that cannot be discovered as they don't implement any unique custom scheme may be invoked by iOS. - Fixed the issues that were preventing the build for iOS. Example domain was one such aspect that was fixed in Android app for the example, too. Recreation of the package was used to fix some. - Added logo images for iOS apps that implement 'upi' custom scheme and are launchable hence Multiple apps support - Play Store and App Store were searched to find an almost exhaustive list of apps and they were played with to figure out their current status of working. All the apps are added to the package along with their identity and status information. Package behaviour and presentation changes - Earlier, this package looked to assume ownership of UPI app functionality/working. However; with changing/evolving UPI apps ecosystem, this needs to be incorporated periodically. - All the dynamics of the UPI apps' behaviour is now captured in the package, and though the default behaviour of the package is to present only the completely successfully working apps to the user, now the user can see all supported by the package currently if he/she requires to experiment for themselves. This avoids repetitive UPI apps verification work across the dev community. Android Intent cleanups - For discovering, the intent call should just resemble upi://pay?. There is no need for dummy parameters. - Removed the commented out version of earlier intent preparation logic Restructuring - Existing structure changed such that upi_pay.dart serves as library wrapper only, exporting relevant modules, and existing and new code are moved into multiple unit modules, towards more maintainable code Docs - Added comments in public APIs, classes and enums and generated doc using dartdoc Cleanups/Improvements - Dependencies cleaned up in pubspec.yaml and moved to latest UPI Applications Status README - Contains the application status records as per the verifications done during April, 2021 (ended 19-Apr-2021) Added new screen capture GIFs Update README.md - Changed README with more compact documentation indicating inclusion of iOS support and how the package can be used for both production and experimentation.
Configuration menu - View commit details
-
Copy full SHA for 8f48ebb - Browse repository at this point
Copy the full SHA 8f48ebbView commit details
Commits on Apr 28, 2021
-
Removed dart:io usage for any platform failure on apps compiling with it and trying to use any functions leading to Platform usage crashes
Configuration menu - View commit details
-
Copy full SHA for b0849c9 - Browse repository at this point
Copy the full SHA b0849c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 109b176 - Browse repository at this point
Copy the full SHA 109b176View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.