iOS support, support for more apps, measures for ensuring production and experimentation modes #17
Conversation
Support for several apps added including verification of end-to-end working. Apps found by searching for "BHIM" and "UPI" on play store and app store and also from these links: https://www.upichalega.com/upi-partners.php https://www.npci.org.in/upi-PSP&3rdpartyApps https://www.npci.org.in/upi-live-members https://www.sebi.gov.in/sebiweb/other/OtherAction.do?doRecognisedFpi=yes&intmId=43
|
Testing done: ran the upi_pay example on an Android device and verified that all installed UPI apps got detected.
|
|
@pepsighan Should we remove support for MiPay, AirtelPay and Truecaller? And bump this into a major version. |
|
Hey @reeteshranjan What's you call on fixing the MiPay package Id i.e. having both the packages id added in this PR? Since, it will expanding the supported apps. It makes sense to have MiPay fiasco handled in as well. |
Yes will add a commit to include both package IDs. Have seen all discussion around the 2 MiPay packages. |
Main repo merge
reeteshranjan
changed the title
reeteshranjan
force-pushed
the
master
branch
3 times, most recently
from
6545762
to
4a2d5bd
Compare
iOS Support - iOS method channel providing canLaunch and launch methods towards discovering UPI apps and launching them respectively. - Added the custom schemes of the iOS apps in the example app's Info.plist to make iOS payment work in the example app. - Changed the example app to show different views for Android and iOS. Android view is same as before. iOS view clearly shows that none of the apps can be picked by the user, as on iOS they are picked by iOS against the upi://pay? calls made to make the UPI transaction. The iOS view also shows that some of the apps that cannot be discovered as they don't implement any unique custom scheme may be invoked by iOS. - Fixed the issues that were preventing the build for iOS. Example domain was one such aspect that was fixed in Android app for the example, too. Recreation of the package was used to fix some. - Added logo images for iOS apps that implement 'upi' custom scheme and are launchable hence Multiple apps support - Play Store and App Store were searched to find an almost exhaustive list of apps and they were played with to figure out their current status of working. All the apps are added to the package along with their identity and status information. Package behaviour and presentation changes - Earlier, this package looked to assume ownership of UPI app functionality/working. However; with changing/evolving UPI apps ecosystem, this needs to be incorporated periodically. - All the dynamics of the UPI apps' behaviour is now captured in the package, and though the default behaviour of the package is to present only the completely successfully working apps to the user, now the user can see all supported by the package currently if he/she requires to experiment for themselves. This avoids repetitive UPI apps verification work across the dev community. Android Intent cleanups - For discovering, the intent call should just resemble upi://pay?. There is no need for dummy parameters. - Removed the commented out version of earlier intent preparation logic Restructuring - Existing structure changed such that upi_pay.dart serves as library wrapper only, exporting relevant modules, and existing and new code are moved into multiple unit modules, towards more maintainable code Docs - Added comments in public APIs, classes and enums and generated doc using dartdoc Cleanups/Improvements - Dependencies cleaned up in pubspec.yaml and moved to latest UPI Applications Status README - Contains the application status records as per the verifications done during April, 2021 (ended 19-Apr-2021) Added new screen capture GIFs Update README.md - Changed README with more compact documentation indicating inclusion of iOS support and how the package can be used for both production and experimentation.
|
@drenther do you plan to merge this pull request? If not, it is OK if I submit this work as a new plugin with upi_pay duly credited and referenced? The point is that I want the work to reach in hands of more developers. |
|
I did not know of this PR being completed. I thought it was still WIP. If you want I can move this package to a org and bring you in as a member in it. That way the community doesn't fragment and it comes under a platform where others can join in more easily. Let me know what you think. |
I did not get that you need more information to know that this is not WIP; because there is no movement on any of my comments across all the relevant issues, so thought this package's development is not in your priority right now. Typically, I would expect some activity from package owners after updates in pull request and comments across relevant issues which could tell me either way - the package is looking for merges, or not. Could you please look at all the changes and push any review comments out, so I know if this pull request is ready to merge or you expect any more changes? |
|
Sure will do. Overall the PR looks good to me. But the changes are quite massive and deviate a lot from what the initial package was. Since you made the massive effort of going through this effort. Would you like to be involved with maintaining the project. If you do I have already sent an invite to this repo and will add you as a publisher in pub.dev the same. |
Sure I'll be more than happy to maintain the package and continue the work like done in this PR. I'm very close to testing UPI merchant payments next, which will be my next PR that should stabilise this package's utility and bring lot of clarity to all the users. Accepted the invite. Thanks for inviting me! |
|
Glad to have you onboard. I wasn't active for personal reasons and would highly appreciate the help here. I have sent a typo filled mail on the email I found on your profile to ask for your pub.dev details to invite you as a publisher. |
|
@drenther do you have any further process remaining to go before merging this PR? |
|
Looks good to me. May be we will do a docs revamp later. But I don't think this PR needs to remain open for that. Please go ahead and merge. |
OK. Just in case you have not looked at the new README.md (it's completely revamped with more information about the UPI related findings etc.) and the new APPS.md with apps information, then please look at it. I did that work to get the documentation in sync with where the work on functionality in this PR has reached. |
|
Yea the README and it looks great and gives all the setup you need to use it in either case. I was just referring to may be a doc site in future. Hence, I said I see no reason for the PR to stay open the README is all in sync. |
OK. Not sure how the API doc sites get built; but I did improve the dartdoc comments documentation and generated the documentation using dartdoc. It's in doc/ folder that got added with this. If that's what will create the API docs, then we have that covered, too. |
|
Thanks again for this behemoth of a PR and the massive effort and patience on this! |
Support for several apps added including verification of end-to-end
working.
Apps found by searching for "BHIM" and "UPI" on play store and app
store and also from these links:
https://www.upichalega.com/upi-partners.php
https://www.npci.org.in/upi-PSP&3rdpartyApps
https://www.npci.org.in/upi-live-members
https://www.sebi.gov.in/sebiweb/other/OtherAction.do?doRecognisedFpi=yes&intmId=43
[Part of work to resolve issue #15]