Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-61115: [C++] Update fast_float version to 3.10.1 (#36434) #34

Merged
merged 1 commit into from
Jul 21, 2023
Merged

DX-61115: [C++] Update fast_float version to 3.10.1 (#36434) #34

merged 1 commit into from
Jul 21, 2023

Conversation

xxlaykxx
Copy link

@xxlaykxx xxlaykxx commented Jul 21, 2023

apache#36434 chery-pick changes from apache arrow

### Rationale for this change

Need this for parsing Infinity values with + sign.

### What changes are included in this PR?

updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors)

### Are these changes tested?
 
in scope of fast_float.

### Are there any user-facing changes?
no

* Closes: apache#36433

Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com>
Co-authored-by: Ivan Chesnov <xxxlaykxxx@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@github-actions
Copy link

❌ GitHub issue apache#36433 could not be retrieved.

@xxlaykxx xxlaykxx changed the title GH-36433: [C++] Update fast_float version to 3.10.1 (#36434) DX-61115: [C++] Update fast_float version to 3.10.1 (#36434) Jul 21, 2023
@xxlaykxx xxlaykxx merged commit bbec8d5 into dremio:dremio-12.0-main Jul 21, 2023
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant