Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Update fast_float version for parsing Infinity values with + sign #36433

Closed
xxlaykxx opened this issue Jul 2, 2023 · 0 comments · Fixed by #36434
Closed

[C++] Update fast_float version for parsing Infinity values with + sign #36433

xxlaykxx opened this issue Jul 2, 2023 · 0 comments · Fixed by #36434
Assignees
@xxlaykxx
Labels
Component: C++ - Gandiva Type: enhancement
Milestone
14.0.0

Comments

@xxlaykxx
Copy link
Contributor

xxlaykxx commented Jul 2, 2023 •
edited
Loading

Describe the enhancement requested

Update fast_float version to 3.10.1.
after 3.10.1 they started using c++ 20 and it cause a lot of build errors. In reality - need in parse_number.h

#ifdef FASTFLOAT_ALLOWS_LEADING_PLUS // disabled by default
  if (*first == UC('+')) {
      ++first;
  }

for parsing Infinity values with + sign
xxlaykxx added a commit to bookingnizer/arrow-apache that referenced this issue Jul 2, 2023
@xxlaykxx
apacheGH-36433 updated fast_float version to 5.2.0
68c7eec
@github-actions github-actions bot mentioned this issue Jul 2, 2023
Merged
@xxlaykxx xxlaykxx changed the title [C++] Update fast_float version to 5.2.0 [C++] Update fast_float version Jul 4, 2023
@kou kou changed the title [C++] Update fast_float version [C++] Update fast_float version for parsing Infinity values with + sign Jul 6, 2023
xxlaykxx added a commit to bookingnizer/arrow-apache that referenced this issue Jul 11, 2023
@xxlaykxx
Merge branch 'apache:main' into apacheGH-36433
028b175
xxlaykxx added a commit to bookingnizer/arrow-apache that referenced this issue Jul 18, 2023
@xxlaykxx
Merge branch 'apache:main' into apacheGH-36433
2a5eef6
xxlaykxx added a commit to bookingnizer/arrow-apache that referenced this issue Jul 18, 2023
@xxlaykxx
Merge branch 'apache:main' into apacheGH-36433
89e16f0
kou added a commit that referenced this issue Jul 19, 2023
@xxlaykxx @kou
GH-36433: [C++] Update fast_float version to 3.10.1 (#36434)
3f0b620 
### Rationale for this change

Need this for parsing Infinity values with + sign.

### What changes are included in this PR?

updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors)

### Are these changes tested?
 
in scope of fast_float.

### Are there any user-facing changes?
no

* Closes: #36433

Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com>
Co-authored-by: Ivan Chesnov <xxxlaykxxx@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Jul 19, 2023
chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this issue Jul 20, 2023
@xxlaykxx @kou @chelseajonesr
apacheGH-36433: [C++] Update fast_float version to 3.10.1 (apache#36434)
43380c0 
### Rationale for this change

Need this for parsing Infinity values with + sign.

### What changes are included in this PR?

updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors)

### Are these changes tested?
 
in scope of fast_float.

### Are there any user-facing changes?
no

* Closes: apache#36433

Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com>
Co-authored-by: Ivan Chesnov <xxxlaykxxx@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@github-actions github-actions bot mentioned this issue Jul 21, 2023
Merged
xxlaykxx added a commit to dremio/arrow that referenced this issue Jul 21, 2023
@xxlaykxx @kou
apacheGH-36433: [C++] Update fast_float version to 3.10.1 (apache#36434…
bbec8d5 
…) (#34)

### Rationale for this change

Need this for parsing Infinity values with + sign.

### What changes are included in this PR?

updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors)

### Are these changes tested?
 
in scope of fast_float.

### Are there any user-facing changes?
no

* Closes: apache#36433

Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com>

Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@xxlaykxx xxlaykxx mentioned this issue Jul 24, 2023
Merged
xxlaykxx added a commit to dremio/arrow that referenced this issue Jul 24, 2023
@xxlaykxx @kou
apacheGH-36433: [C++] Update fast_float version to 3.10.1 (apache#36434…
cddcd3b 
…) (#35)

### Rationale for this change

Need this for parsing Infinity values with + sign.

### What changes are included in this PR?

updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors)

### Are these changes tested?
 
in scope of fast_float.

### Are there any user-facing changes?
no

* Closes: apache#36433

Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com>

Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
lriggs pushed a commit to dremio/arrow that referenced this issue Jul 28, 2023
@xxlaykxx @kou @lriggs
apacheGH-36433: [C++] Update fast_float version to 3.10.1 (apache#36434…
7f71473 
…) (#35)

### Rationale for this change

Need this for parsing Infinity values with + sign.

### What changes are included in this PR?

updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors)

### Are these changes tested?
 
in scope of fast_float.

### Are there any user-facing changes?
no

* Closes: apache#36433

Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com>

Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@xxlaykxx @kou @R-JunmingChen
apacheGH-36433: [C++] Update fast_float version to 3.10.1 (apache#36434)
9bf29eb 
### Rationale for this change

Need this for parsing Infinity values with + sign.

### What changes are included in this PR?

updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors)

### Are these changes tested?
 
in scope of fast_float.

### Are there any user-facing changes?
no

* Closes: apache#36433

Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com>
Co-authored-by: Ivan Chesnov <xxxlaykxxx@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@xxlaykxx @kou @loicalleyne
apacheGH-36433: [C++] Update fast_float version to 3.10.1 (apache#36434)
c0ea39b 
### Rationale for this change

Need this for parsing Infinity values with + sign.

### What changes are included in this PR?

updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors)

### Are these changes tested?
 
in scope of fast_float.

### Are there any user-facing changes?
no

* Closes: apache#36433

Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com>
Co-authored-by: Ivan Chesnov <xxxlaykxxx@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xxlaykxx xxlaykxx

Labels
Component: C++ - Gandiva Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36433: [C++] Update fast_float version to 3.10.1 bookingnizer/arrow-apache
2 participants
@kou @xxlaykxx