-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Update fast_float version for parsing Infinity values with + sign #36433
Comments
xxlaykxx
added a commit
to bookingnizer/arrow-apache
that referenced
this issue
Jul 2, 2023
xxlaykxx
changed the title
[C++] Update fast_float version to 5.2.0
[C++] Update fast_float version
Jul 4, 2023
kou
changed the title
[C++] Update fast_float version
[C++] Update fast_float version for parsing Infinity values with + sign
Jul 6, 2023
xxlaykxx
added a commit
to bookingnizer/arrow-apache
that referenced
this issue
Jul 11, 2023
xxlaykxx
added a commit
to bookingnizer/arrow-apache
that referenced
this issue
Jul 18, 2023
xxlaykxx
added a commit
to bookingnizer/arrow-apache
that referenced
this issue
Jul 18, 2023
kou
added a commit
that referenced
this issue
Jul 19, 2023
### Rationale for this change Need this for parsing Infinity values with + sign. ### What changes are included in this PR? updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors) ### Are these changes tested? in scope of fast_float. ### Are there any user-facing changes? no * Closes: #36433 Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com> Co-authored-by: Ivan Chesnov <xxxlaykxxx@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
chelseajonesr
pushed a commit
to chelseajonesr/arrow
that referenced
this issue
Jul 20, 2023
### Rationale for this change Need this for parsing Infinity values with + sign. ### What changes are included in this PR? updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors) ### Are these changes tested? in scope of fast_float. ### Are there any user-facing changes? no * Closes: apache#36433 Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com> Co-authored-by: Ivan Chesnov <xxxlaykxxx@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
xxlaykxx
added a commit
to dremio/arrow
that referenced
this issue
Jul 21, 2023
…) (#34) ### Rationale for this change Need this for parsing Infinity values with + sign. ### What changes are included in this PR? updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors) ### Are these changes tested? in scope of fast_float. ### Are there any user-facing changes? no * Closes: apache#36433 Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
xxlaykxx
added a commit
to dremio/arrow
that referenced
this issue
Jul 24, 2023
…) (#35) ### Rationale for this change Need this for parsing Infinity values with + sign. ### What changes are included in this PR? updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors) ### Are these changes tested? in scope of fast_float. ### Are there any user-facing changes? no * Closes: apache#36433 Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
lriggs
pushed a commit
to dremio/arrow
that referenced
this issue
Jul 28, 2023
…) (#35) ### Rationale for this change Need this for parsing Infinity values with + sign. ### What changes are included in this PR? updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors) ### Are these changes tested? in scope of fast_float. ### Are there any user-facing changes? no * Closes: apache#36433 Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this issue
Aug 20, 2023
### Rationale for this change Need this for parsing Infinity values with + sign. ### What changes are included in this PR? updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors) ### Are these changes tested? in scope of fast_float. ### Are there any user-facing changes? no * Closes: apache#36433 Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com> Co-authored-by: Ivan Chesnov <xxxlaykxxx@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
### Rationale for this change Need this for parsing Infinity values with + sign. ### What changes are included in this PR? updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors) ### Are these changes tested? in scope of fast_float. ### Are there any user-facing changes? no * Closes: apache#36433 Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com> Co-authored-by: Ivan Chesnov <xxxlaykxxx@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Update fast_float version to 3.10.1.
after 3.10.1 they started using c++ 20 and it cause a lot of build errors. In reality - need in parse_number.h
for parsing Infinity values with + sign
The text was updated successfully, but these errors were encountered: