Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1574] fix publication menu issue when unpublished #885

Merged
merged 2 commits into from
Oct 6, 2023
Merged

[R20-1574] fix publication menu issue when unpublished #885

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b737e32
chore(@dpc-sdp/ripple-tide-publication): :bug: [R20-1574] fix publica…
dylankelly Oct 6, 2023
acd09f3
chore(@dpc-sdp/ripple-tide-publication): :rotating_light: fix unused var
dylankelly Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/ripple-tide-publication/server/api/tide/publication-index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import jsonapiParse from 'jsonapi-parse'
import { defineEventHandler, getQuery, H3Event } from 'h3'
import { createHandler, TideApiBase, logger } from '@dpc-sdp/ripple-tide-api'
import {
ApplicationError,
BadRequestError
} from '@dpc-sdp/ripple-tide-api/errors'
import { BadRequestError } from '@dpc-sdp/ripple-tide-api/errors'
import type {
RplTideModuleConfig,
IRplTideModuleMapping,
Expand Down Expand Up @@ -69,10 +66,8 @@ class TidePublicationIndexApi extends TideApiBase {
)
return siteData
} catch (error: any) {
// Could be 404?
throw new ApplicationError('Error fetching publication index', {
cause: error
})
// Could be 404? publication could be in share or preview so need to ignore this error and render page anyway
logger.error(`Error fetching publication index`, error)
}
}
}
Expand Down