Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1574] fix publication menu issue when unpublished #885

Merged
merged 2 commits into from
Oct 6, 2023
Merged

[R20-1574] fix publication menu issue when unpublished #885

merged 2 commits into from
Oct 6, 2023

Conversation

dylankelly
Copy link
Contributor

@dylankelly dylankelly commented Oct 6, 2023 •
edited
Loading

…tion preview menu issue

Issue:

What I did

  • Made publication menu API log error when it can not fetch the menu. For unpublished pages it should still render the page without the menu.

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@dylankelly dylankelly changed the title chore(@dpc-sdp/ripple-tide-publication): 🐛 [R20-1574] fix publica… [R20-1574] fix publication menu issue when unpublished Oct 6, 2023
@cypress
Copy link

cypress bot commented Oct 6, 2023 •
edited
Loading

Passing run #778 ↗︎

0 99 0 0 Flakiness 0

Details:

chore(@dpc-sdp/ripple-tide-publication): 🚨 fix unused var
Project: ripple-framework Commit: acd09f34be
Status: Passed Duration: 07:08 💡
Started: Oct 6, 2023 2:41 AM Ended: Oct 6, 2023 2:48 AM

Review all test suite changes for PR #885 ↗︎

@dylankelly dylankelly merged commit 5b8d272 into release/2.3.4 Oct 6, 2023
@cypress cypress bot mentioned this pull request Oct 6, 2023
Merged
6 tasks
@waitingallday waitingallday deleted the fix/R20-1574-publication-preview branch October 25, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylankelly @waitingallday @jeffdowdle