Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1505] fix(nuxt-ripple): 🐛 fix title undefined in search page #823

Merged
merged 2 commits into from
Sep 4, 2023
Merged

[R20-1505] fix(nuxt-ripple): 🐛 fix title undefined in search page #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60988fe
fix(nuxt-ripple): :bug: fix title undefined in search page
dylankelly Aug 31, 2023
1a43cab
Merge branch 'develop' into feature/fix-undefined-title
dylankelly Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
190 changes: 98 additions & 92 deletions packages/nuxt-ripple/plugins/social-meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,116 +12,122 @@ export default defineNuxtPlugin((nuxtApp) => {
const site = props.site

const pageTitle = computed(() => {
const titleOfPage = `${props.pageTitle || props.page?.title}`
const titleOfPage = `${props.pageTitle || props.page?.title || ''}`
const titleOfSite = `${props.site?.name}`
if (titleOfPage && titleOfSite) {
return `${titleOfPage} | ${titleOfSite}`
}
return titleOfSite
})

// Additional <link>s in head
const links = []
const additionalMeta = page.meta?.additional || []

additionalMeta
.filter((attr: any) => attr.tag === 'link')
.map((attr: any) => {
if (attr.attributes.rel) links.push(attr.attributes)
if (!page) {
useHead({
title: pageTitle
})
} else {
// Additional <link>s in head
const links = []
const additionalMeta = page?.meta?.additional || []

// Define basic attributes
useHead({
link: links
})
additionalMeta
.filter((attr: any) => attr.tag === 'link')
.map((attr: any) => {
if (attr.attributes.rel) links.push(attr.attributes)
})

// Override API values with metatag
const metaDescriptions = {
ogDescription: '',
description: ''
},
metaOverrides = {}
additionalMeta
.filter(
(attr: any) => attr.tag === 'meta' && attr.attributes.name !== 'title'
)
.map((attr: any) => {
if (attr.attributes.name || attr.attributes.property)
if (
['ogDescription', 'description'].includes(
metaProperty(attr.attributes.name || attr.attributes.property)
)
) {
// Keep description fields in a separate collection
metaDescriptions[
metaProperty(attr.attributes.name || attr.attributes.property)
] = attr.attributes.content
} else {
metaOverrides[
metaProperty(attr.attributes.name || attr.attributes.property)
] = attr.attributes.content
}
// Define basic attributes
useHead({
link: links
})

// Determine unified description
let description = page.meta?.description
// Override API values with metatag
const metaDescriptions = {
ogDescription: '',
description: ''
},
metaOverrides = {}
additionalMeta
.filter(
(attr: any) => attr.tag === 'meta' && attr.attributes.name !== 'title'
)
.map((attr: any) => {
if (attr.attributes.name || attr.attributes.property)
if (
['ogDescription', 'description'].includes(
metaProperty(attr.attributes.name || attr.attributes.property)
)
) {
// Keep description fields in a separate collection
metaDescriptions[
metaProperty(attr.attributes.name || attr.attributes.property)
] = attr.attributes.content
} else {
metaOverrides[
metaProperty(attr.attributes.name || attr.attributes.property)
] = attr.attributes.content
}
})

if (metaDescriptions.ogDescription !== '') {
description = metaDescriptions.ogDescription
} else if (metaDescriptions.description !== '') {
description = metaDescriptions.description
}
// Determine unified description
let description = page.meta?.description

// Determine images
let featuredImage = '',
featuredImageAlt = ''
if (page.meta?.image) {
featuredImage = page.meta.image.src
featuredImageAlt = page.meta.image.alt
} else if (site.socialImages.og) {
featuredImage = site.socialImages.og.src
featuredImageAlt = site.socialImages.og.alt
}
if (metaDescriptions.ogDescription !== '') {
description = metaDescriptions.ogDescription
} else if (metaDescriptions.description !== '') {
description = metaDescriptions.description
}

let twitterImage = '',
twitterImageAlt = ''
if (page.meta?.image) {
twitterImage = page.meta.image.src
twitterImageAlt = page.meta.image.alt
} else if (site.socialImages.twitter) {
twitterImage = site.socialImages.twitter.src
twitterImageAlt = site.socialImages.twitter.alt
} else if (site.socialImages.og) {
twitterImage = site.socialImages.og.src
twitterImageAlt = site.socialImages.og.alt
}
// Determine images
let featuredImage = '',
featuredImageAlt = ''
if (page.meta?.image) {
featuredImage = page.meta.image.src
featuredImageAlt = page.meta.image.alt
} else if (site.socialImages.og) {
featuredImage = site.socialImages.og.src
featuredImageAlt = site.socialImages.og.alt
}

const { $app_origin } = useNuxtApp()
let twitterImage = '',
twitterImageAlt = ''
if (page.meta?.image) {
twitterImage = page.meta.image.src
twitterImageAlt = page.meta.image.alt
} else if (site.socialImages.twitter) {
twitterImage = site.socialImages.twitter.src
twitterImageAlt = site.socialImages.twitter.alt
} else if (site.socialImages.og) {
twitterImage = site.socialImages.og.src
twitterImageAlt = site.socialImages.og.alt
}

// Define SEO meta
useSeoMeta({
title: () => pageTitle.value,
description: () => description,
ogTitle: props.pageTitle,
ogDescription: description,
ogType: 'website',
ogUrl: $app_origin + page.meta?.url,
ogImage: featuredImage,
ogImageAlt: featuredImageAlt,
twitterCard: 'summary',
twitterSite: $app_origin,
twitterTitle: props.pageTitle,
twitterDescription: description,
twitterImage: twitterImage,
twitterImageAlt: twitterImageAlt,
keywords: page.meta?.keywords,
const { $app_origin } = useNuxtApp()

// Custom props
sitesection: props.siteSection ? props.siteSection.name : null,
'content-type': page.type && page.type.replace('node--', ''),
// Define SEO meta
useSeoMeta({
title: () => pageTitle.value,
description: () => description,
ogTitle: props.pageTitle,
ogDescription: description,
ogType: 'website',
ogUrl: $app_origin + page.meta?.url,
ogImage: featuredImage,
ogImageAlt: featuredImageAlt,
twitterCard: 'summary',
twitterSite: $app_origin,
twitterTitle: props.pageTitle,
twitterDescription: description,
twitterImage: twitterImage,
twitterImageAlt: twitterImageAlt,
keywords: page.meta?.keywords,

// Metatag escape hatch
...metaOverrides
})
// Custom props
sitesection: props.siteSection ? props.siteSection.name : null,
'content-type': page.type && page.type.replace('node--', ''),

// Metatag escape hatch
...metaOverrides
})
}
})
})
2 changes: 1 addition & 1 deletion packages/ripple-tide-search/components/TideSearchPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ watch(
</script>

<template>
<TideBaseLayout :id="id" :site="site">
<TideBaseLayout :id="id" :site="site" :pageTitle="pageTitle">
<template #aboveBody>
<RplHeroHeader
:title="pageTitle"
Expand Down