Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1505] fix(nuxt-ripple): 🐛 fix title undefined in search page #823

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

dylankelly
Copy link
Contributor

@dylankelly dylankelly commented Aug 31, 2023

Issue: R20-1505

What I did

  • Added missing title prop in search page
  • only add seo meta tags if page is defined

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 1a43cab
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64f03b742d38d2000870a32f

@dylankelly dylankelly self-assigned this Aug 31, 2023
@cypress
Copy link

cypress bot commented Aug 31, 2023

Passing run #565 ↗︎

0 93 0 0 Flakiness 0

Details:

Merge branch 'develop' into feature/fix-undefined-title
Project: ripple-framework Commit: 1a43cab8df
Status: Passed Duration: 04:52 💡
Started: Aug 31, 2023 7:07 AM Ended: Aug 31, 2023 7:12 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dylankelly dylankelly changed the title fix(nuxt-ripple): 🐛 fix title undefined in search page [R20-1505] fix(nuxt-ripple): 🐛 fix title undefined in search page Aug 31, 2023
@dylankelly dylankelly added this pull request to the merge queue Sep 4, 2023
Merged via the queue into develop with commit 322c9cf Sep 4, 2023
16 of 17 checks passed
@waitingallday waitingallday deleted the feature/fix-undefined-title branch October 25, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants