Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1989] make sure topic/tags have a name #1169

Merged
merged 1 commit into from
May 19, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented May 16, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1989

What I did

  • Make sure topics/tags only show if they have a name

Seems like Drupal can return an "invalid" tags, so now we just make sure the topic/tag has a name.
Screenshot 2024-05-16 at 1 35 34 PM

Before
Screenshot 2024-05-16 at 2 50 48 PM

After
Screenshot 2024-05-16 at 2 52 42 PM

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this May 16, 2024
Copy link

netlify bot commented May 16, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 22f8e79
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/664591619df18e0008d75e91

Copy link

cypress bot commented May 16, 2024

Passing run #1731 ↗︎

0 150 0 0 Flakiness 0

Details:

feat(@dpc-sdp/nuxt-ripple): make sure topic/tags have a name
Project: ripple-framework Commit: 22f8e79578
Status: Passed Duration: 06:42 💡
Started: May 16, 2024 4:59 AM Ended: May 16, 2024 5:06 AM

Review all test suite changes for PR #1169 ↗︎

@waitingallday waitingallday merged commit c1f7f33 into develop May 19, 2024
8 checks passed
@waitingallday waitingallday deleted the bugfix/R20-1989-empty-tags branch May 19, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants