Merge pull request #1169 from dpc-sdp/bugfix/R20-1989-empty-tags

[R20-1989] make sure topic/tags have a name
dpc-sdp · May 19, 2024 · c1f7f33 · c1f7f33
2 parents 80e528c + 22f8e79
commit c1f7f33
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/packages/nuxt-ripple/mapping/base/topic-tags/topic-tags-mapping.ts b/packages/nuxt-ripple/mapping/base/topic-tags/topic-tags-mapping.ts
@@ -8,19 +8,23 @@ export interface TideTopicTag {
 export const map = (src: TideApiResponse): TideTopicTag[] => {
   const topics: TideTopicTag[] = []
 
-  if (src.field_topic) {
+  if (src.field_topic?.name) {
     topics.push({
       text: src.field_topic.name,
       url: src.field_topic.path?.alias || ''
     })
   }
 
-  const tags = (src.field_tags || []).map((rawTag) => {
-    return {
-      text: rawTag.name,
-      url: rawTag.path?.alias || ''
-    }
-  })
+  const tags = (src.field_tags || [])
+    .map((rawTag: any) => {
+      if (!rawTag?.name) return null
+
+      return {
+        text: rawTag.name,
+        url: rawTag.path?.alias || ''
+      }
+    })
+    .filter(Boolean)
 
   return [...topics, ...tags]
 }