Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V9.5.1 rc #188

Merged
merged 13 commits into from
Dec 7, 2019
Merged

V9.5.1 rc #188

merged 13 commits into from
Dec 7, 2019

Conversation

doug-martin
Copy link
Owner

@codecov
Copy link

codecov bot commented Dec 7, 2019

Codecov Report

Merging #188 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   96.24%   96.19%   -0.06%     
==========================================
  Files          56       56              
  Lines        3994     3994              
==========================================
- Hits         3844     3842       -2     
- Misses        135      137       +2     
  Partials       15       15
Impacted Files Coverage Δ
sqlgen/expression_sql_generator.go 100% <ø> (ø) ⬆️
exp/delete_clauses.go 95.23% <100%> (ø) ⬆️
exp/insert_clauses.go 100% <100%> (ø) ⬆️
update_dataset.go 100% <100%> (ø) ⬆️
dialect/sqlite3/sqlite3.go 100% <100%> (ø) ⬆️
select_dataset.go 99.27% <100%> (-0.73%) ⬇️
exp/update_clauses.go 96.07% <100%> (ø) ⬆️
delete_dataset.go 100% <100%> (ø) ⬆️
insert_dataset.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe8322...17dbd79. Read the comment docs.

* [FIXED] SQlite dialect escapes single quotes wrong, leads to SQL syntax error [#178](#178)
* Removed check for returning columns when using insert/update/delete in sub select
[FIXED] WITH clause without a RETURNING clause will panic [#177]
@doug-martin doug-martin merged commit 1dd9123 into master Dec 7, 2019
@doug-martin doug-martin deleted the v9.5.1-rc branch October 16, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants