Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] WITH clause without a RETURNING clause will panic [#177] #190

Merged
merged 1 commit into from
Dec 7, 2019

Conversation

doug-martin
Copy link
Owner

  • Removed check for returning columns when using insert/update/delete in sub select

* Removed check for returning columns when using insert/update/delete in sub select
@codecov
Copy link

codecov bot commented Dec 7, 2019

Codecov Report

Merging #190 into v9.5.1-rc will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           v9.5.1-rc     #190      +/-   ##
=============================================
- Coverage      96.24%   96.19%   -0.06%     
=============================================
  Files             56       56              
  Lines           3997     3994       -3     
=============================================
- Hits            3847     3842       -5     
- Misses           135      137       +2     
  Partials          15       15
Impacted Files Coverage Δ
sqlgen/expression_sql_generator.go 100% <ø> (ø) ⬆️
select_dataset.go 99.27% <0%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 096254c...864162a. Read the comment docs.

@doug-martin doug-martin added this to the v9.5.1 milestone Dec 7, 2019
@doug-martin doug-martin merged commit 17dbd79 into v9.5.1-rc Dec 7, 2019
@doug-martin doug-martin deleted the issue177 branch October 16, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant