SDK content diffs - .NET 9 - roslyn

[ellahathaway]

Microsoft and source-built SDKs contain the following difference related to roslyn content and packages. There should be no unintentional differences.

All intentional differences should be captured in SDK diff exclusion file:

Related files only present in Source-built SDK:

./sdk/x.y.z/Roslyn/bincore/System.Collections.Immutable.dll
./sdk/x.y.z/Roslyn/bincore/System.Reflection.Metadata.dll

Related to #4013

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ellahathaway]

I believe that this may be related to dotnet/dotnet@1d89b47.

The VMR does not include ./sdk/x.y.z/Roslyn/bincore/Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler.dll because it was removed in dotnet/dotnet@1d89b47.

However, the package is still included in the format repo: https://github.com/dotnet/format/blob/main/Directory.Packages.props#L41.

cc/@mthalman

[mthalman]

This is because of dotnet/format#2075.

The reason it's not in the VMR is because we have a patch that removes it.

This is essentially a version coherency issue. The format repo needs to update its dependency to be a newer version of Roslyn.

Because of that, this SDK diff is expected.

[ellahathaway]

Possibly added back in by dotnet/roslyn#73697?

[mthalman]

In general, it's preferred to open a new issue in this case since the original issue was successfully resolved.

[ellahathaway]

In general, it's preferred to open a new issue in this case since the original issue was successfully resolved.

Good to know! I'll be sure to do that next time :)

[ellahathaway]

The diffs are no longer appearing in the latest build (internal Microsoft link). This is the second time these diffs have appeared and disappeared, so I think that it is still worth investigating what is causing these diffs.

[ellahathaway]

Diffs removed from baseline in dotnet/sdk#42393 - continuing to investigate

[ellahathaway]

The diffs were removed with the rebootstrapping that occured: dotnet/dotnet@2053724. Closing this issue.