Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Source-Build SDK Diff Tests Baselines and Exclusions #41716

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Update Source-Build SDK Diff Tests Baselines and Exclusions #41716

merged 3 commits into from
Jul 2, 2024

Conversation

dotnet-sb-bot
Copy link
Contributor

@dotnet-sb-bot dotnet-sb-bot commented Jun 21, 2024 •
edited
Loading

This PR was created by the CreateBaselineUpdatePR tool for build 2486711.

The updated test results can be found at https://dev.azure.com/dnceng/internal/_build/results?buildId=2486711 (internal Microsoft link)

@dotnet-sb-bot dotnet-sb-bot requested review from a team as code owners June 21, 2024 11:09
@build-analysis build-analysis bot mentioned this pull request Jun 21, 2024
Open
3 tasks
ellahathaway
ellahathaway reviewed Jun 21, 2024
View reviewed changes
...nt/test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/SdkContentTests/MsftToSbSdkFiles.diff Outdated
Comment on lines 597 to 598
+./sdk/x.y.z/Roslyn/bincore/System.Reflection.Metadata.dll
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reopened dotnet/source-build#4016

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will readd exclusion and resolve with dotnet/source-build#4016

@ellahathaway ellahathaway requested a review from a team June 21, 2024 18:30
@build-analysis build-analysis bot mentioned this pull request Jun 21, 2024
Open
@ellahathaway ellahathaway enabled auto-merge (squash) June 21, 2024 20:08
This was referenced Jun 21, 2024
Open
Open
@build-analysis build-analysis bot mentioned this pull request Jun 27, 2024
Open
@ellahathaway ellahathaway enabled auto-merge (squash) June 27, 2024 15:33
@ellahathaway ellahathaway mentioned this pull request Jun 27, 2024
Closed
@ellahathaway
Copy link
Member

I can't get this PR merged until the checks begin passing (the failures are unrelated to the changes in this PR). Since the PR tool keeps overriding my changes, I'm not going to update this PR again until we know that CI checks will pass.

@ellahathaway
Copy link
Member

Will check in on CI in the morning once this PR gets updated (again) by the PR creator tool. At that point, I'll figure out the associated issue to link to if the CI is still failing, update this PR accordingly, and ping someone one the source-build team to get this merged on red since so far the CI failures have been unrelated.

@build-analysis build-analysis bot mentioned this pull request Jul 2, 2024
Open
3 tasks
@ellahathaway ellahathaway enabled auto-merge (squash) July 2, 2024 16:17
@ellahathaway
Copy link
Member

CI failure is unrelated. @MichaelSimons - could you merge this for me please?

@MichaelSimons MichaelSimons merged commit 8fd7163 into main Jul 2, 2024
33 of 36 checks passed
@MichaelSimons MichaelSimons deleted the pr-baseline-20240621110933 branch July 2, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellahathaway ellahathaway ellahathaway left review comments

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dotnet-sb-bot @ellahathaway @mthalman @MichaelSimons