Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK baseline and exclusions #18374

Merged
merged 7 commits into from
Jan 25, 2024

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway requested a review from a team as a code owner January 24, 2024 23:36
@ellahathaway
Copy link
Member Author

ellahathaway commented Jan 24, 2024

Worked locally, but diffs are showing in the pipeline. Working to resolve before merging.

Edit: now working in Azdo pipeline

./sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.CodeAnalysis.CSharp.Features.dll
./sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.CodeAnalysis.CSharp.Workspaces.dll
./sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.CodeAnalysis.dll
-./sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler.dll
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not intended to be the normal state, I would add this as an exclusion as well, pointing to dotnet/source-build#4016 (comment).

@ellahathaway ellahathaway merged commit 31d8431 into dotnet:main Jan 25, 2024
16 checks passed
@ellahathaway ellahathaway deleted the sdk-content-diff branch January 25, 2024 20:55
@ellahathaway
Copy link
Member Author

/backport to release/9.0.1xx-preview1

Copy link

Started backporting to release/9.0.1xx-preview1: https://github.com/dotnet/installer/actions/runs/7672574447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK content diffs - .NET 9 - roslyn
2 participants