Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden metadata handler invoker against bad metadata #47433

Open
wants to merge 1 commit into
base: release/9.0.3xx
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions src/BuiltInTools/HotReloadAgent/MetadataUpdateHandlerInvoker.cs
Original file line number Diff line number Diff line change
Expand Up @@ -327,15 +327,46 @@ internal static List<Assembly> TopologicalSort(Assembly[] assemblies)

static void Visit(Assembly[] assemblies, Assembly assembly, List<Assembly> sortedAssemblies, HashSet<string> visited)
{
var assemblyIdentifier = assembly.GetName().Name!;
string assemblyIdentifier;

try
{
assemblyIdentifier = assembly.GetName().Name!;
}
catch
{
return;
}

if (!visited.Add(assemblyIdentifier))
{
return;
}

foreach (var dependencyName in assembly.GetReferencedAssemblies())
AssemblyName[] referencedAssemblies;
try
{
var dependency = Array.Find(assemblies, a => a.GetName().Name == dependencyName.Name);
referencedAssemblies = assembly.GetReferencedAssemblies();
}
catch
{
referencedAssemblies = [];
}

foreach (var dependencyName in referencedAssemblies)
{
var dependency = Array.Find(assemblies, a =>
{
try
{
return a.GetName().Name == dependencyName.Name;
}
catch
{
return false;
}
});

if (dependency is not null)
{
Visit(assemblies, dependency, sortedAssemblies, visited);
Expand Down