Harden metadata handler invoker against bad metadata #47433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
PR Overview
This PR strengthens the robustness of the MetadataUpdateHandlerInvoker by gracefully handling cases where assembly metadata retrieval might fail.
- Introduces try-catch blocks around GetName() and GetReferencedAssemblies() calls.
- Returns early or assigns default values when metadata access fails.
Reviewed Changes
| File | Description |
|---|---|
| src/BuiltInTools/HotReloadAgent/MetadataUpdateHandlerInvoker.cs | Added error handling to protect against exceptions when reading assembly metadata |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
|
@phil-allen-msft ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.