Embracing the null #45421
Closed
Embracing the null #45421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
jaredpar
commented
Dec 11, 2024
| @@ -17,6 +17,7 @@ | |||
| <!-- Avoid https://github.com/dotnet/arcade/issues/9305 --> | |||
| <AutoGenerateBindingRedirects>false</AutoGenerateBindingRedirects> | |||
| <Nullable>enable</Nullable> | |||
| <NoWarn Condition="'$(TargetFramework)' == 'net472'">$(NoWarn);Nullable</NoWarn> | |||
There was a problem hiding this comment.
When multi-targeting between net472 or netstandard2.0 and anything else, disable null checking on those TF. Otherwise you end up with non-sense warnings.
There was a problem hiding this comment.
Shouldn't we fix this in a more central location so it applies to all projects and not just cli util?
Seems like I could just chagne my logic here that's DisableNullableWarnings to a NoWarn addition: https://github.com/dotnet/sdk/pull/45420/files#diff-50e91c82311ea26f2a73202525dfdf2b0a89c178ee666b2bf3ad4c84ac4c06dc
There was a problem hiding this comment.
That is fine by me, I was just trying to demonstrate the way to approach this. Did small scale for that.
|
Superseded by #45420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.