Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a set of test issues caused by an old blob feed and try to fix up the nullable change we rushed in #45420

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

marcpopMSFT
Copy link
Member

@marcpopMSFT marcpopMSFT commented Dec 11, 2024

Fixes #45417

Changes included

  • Disable nullable for netframework builds
  • Fix the nullable logic for the stopwatch
  • Remove DotnetCoreBlobFeed as this is a very old feed only needed for one test
  • Delete the dotnet store test that needed that one feed

@marcpopMSFT marcpopMSFT marked this pull request as ready for review December 11, 2024 21:55
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 11, 2024
@marcpopMSFT
Copy link
Member Author

@jaredpar I tried adding your suggestion of disabling nullable warnings for MT netfx builds but that doesn't work: #45420

I can confirm locally that DisableNullableWarnings is true in the netfix CLI.Utils build but I still get this warning: C:\repos\sdk\src\Cli\Microsoft.DotNet.Cli.Utils\Command.cs(82,21): error CS8602: Dereference of a possibly null reference. [C:\repos\sdk\src\Cli\Microsoft.DotNet.Cli.Utils\Microsoft.DotNet.Cli.Utils.csproj]

@jaredpar jaredpar mentioned this pull request Dec 11, 2024
@marcpopMSFT marcpopMSFT requested a review from a team as a code owner December 11, 2024 23:12
@v-wuzhai
Copy link
Member

It could be due to a temporary issue with the network or storage account. Now, these tests have suddenly passed. Therefore, I will close this PR.

@v-wuzhai v-wuzhai closed this Dec 12, 2024
@marcpopMSFT marcpopMSFT reopened this Dec 12, 2024
@marcpopMSFT
Copy link
Member Author

Reactivating as this has templating test fixes and nullable fixes as well.

Additionally, I think we want the change to remove the blob. It has risk of keeping it around and removing simplifies things. Only one test failed which I'll talk to Daniel about.

Microsoft.NET.Publish.Tests.GivenThatWeWantToStoreAProjectWithDependencies.store_nativeonlyassets failed
error NU1101: Unable to find package runtime.osx.10.10-x64.Microsoft.NETCore.CoreDisTools. No packages exist with this id in source(s): dotnet-public, dotnet-tools, dotnet10, dotnet10-transport, dotnet6, dotnet7, dotnet8, dotnet8-transport, dotnet8-workloads, dotnet9, dotnet9-transport, Package source 1, Package source 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
5 participants