[wasm] bump devDependencies to rollup 3 and TypeScript 4.9 #78726

lambdageek · 2022-11-22T20:18:50Z

rollup-plugin-consts hasn't released a version that works with rollup 3. But @rollup/plugin-virtual can do everything that we need from consts.
rollup-plugin-terser is unmaintained and has been superseded by @rollup/plugin-terser
TypeScript 4.9 got rid of a type used by http.ts, but fortunately there's a straightforward replacement for what we need.
fast-glob changed how it exports the sync API

Typescript 4.9 rollup 2.79.1 (can't bump to rollup 3 until rollup-plugin-consts 1.1.1 is published to raise it's upper bound rollup dependency)

replace untmainained rollup-plugin-terser with @rollup/plugin-terser replace rollup-plugin-consts with a shim @rollup/plugin-virtual. They do the same thing, but consts is more opinionated about how it names its modules

lambdageek · 2022-11-22T20:20:35Z

/azp run runtime-wasm

azure-pipelines · 2022-11-22T20:20:46Z

Azure Pipelines successfully started running 1 pipeline(s).

lambdageek · 2022-11-22T21:14:50Z

 npm ERR! code E401
  npm ERR! Unable to authenticate, your authentication token seems to be invalid.
  npm ERR! To correct this please trying logging in again with:
  npm ERR!     npm login
  
  npm ERR! A complete log of this run can be found in:
  npm ERR!     /home/cloudtest_azpcontainer/.npm/_logs/2022-11-22T20_45_44_497Z-debug.log

What does this mean? It seems related to src/mono/wasm/runtime/.npmrc. similar to what was happening with #71393. Any ideas how that issue was resolved? @radical @steveisok

pavelsavara · 2022-11-23T09:53:31Z

What does this mean?

I think it means that some of the NPM packages you use are not in the corporate NPM repository. I think we need to ask first-responders to add the package. Or maybe if we know how to log-in we could do it ourselves.

@maraf do you know how ?

pavelsavara · 2022-11-23T09:55:48Z

"lockfileVersion": 2, please use nodejs version in the emsdk to create the lock file v 1.

pavelsavara · 2022-11-23T09:59:33Z

Just visual sanity check: take the minified dotnet.js, prettify it with some tool and run diff to previous version.
Since emsdk has it's own closure compiler on top of our terser, there may be (new) problems.

maraf · 2022-11-23T10:07:33Z

@maraf Marek Fisera FTE do you know how ?

No idea

lambdageek · 2022-11-23T12:25:58Z

"lockfileVersion": 2, please use nodejs version in the emsdk to create the lock file v 1.

I did the upgrade using npm from emsdk. Is there some trick to make it generate a v1 lockfile?

Update: looks like there's a --lockfile-version option for npm

lambdageek · 2022-11-23T14:15:54Z

Ok I see.

Apparently the workflow has to be something like this (based on #71393 (comment)):

Run source .../emsdk_env.sh so that the EMSDK version of node and npm are used
Run npm cache clean -force
Go to https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-public-npm/connect/npm and setup authentication to the azdo npm registry - on linux/mac login and look at the "Other" tab for instructions on modifying your ~/.npmrc
Edit the package.json to bump the versions
run npm install --lockfile-version=1

And use the dnceng npm registry

lambdageek · 2022-11-23T18:22:54Z

"lockfileVersion": 2, please use nodejs version in the emsdk to create the lock file v 1.

oh I see what happened - my make provision-wasm was fine, but at some point I must have upgraded npm in the emscripten sdk.

lambdageek · 2022-11-23T18:24:02Z

Hmm... rollup potentially doesn't like npm v6. I suspect it doesn't matter for us, but maybe the warning will trip something up on CI

npm WARN notsup Unsupported engine for rollup@3.4.0: wanted: {"node":">=14.18.0","npm":">=8.0.0"} (current: {"node":"14.18.2","npm":"6.14.15"})
npm WARN notsup Not compatible with your version of node/npm: rollup@3.4.0

…cies

lambdageek · 2022-11-23T20:13:41Z

Comparing runtime.es6.iffe.js from this PR and main after running through VS Code "prettier" extension, the only differences I see are the choice of some of the minified variable names (new terser seems to like _ more than d and W more than P)

radical · 2022-11-23T20:17:06Z

..

Run source .../emsdk_env.sh so that the EMSDK version of node and npm are used

Run npm cache clean -force

Go to https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-public-npm/connect/npm and setup authentication to the azdo npm registry - on linux/mac login and look at the "Other" tab for instructions on modifying your ~/.npmrc

Edit the package.json to bump the versions

run npm install --lockfile-version=1

Can this be added to src/mono/wasm/README.md? this and the thing about using specific npm version.

lambdageek · 2022-11-23T21:25:04Z

Can this be added to src/mono/wasm/README.md? this and the thing about using specific npm version.

done

pavelsavara

many thanks!

lambdageek added 3 commits November 22, 2022 15:13

Bump dev dependencies

23b4c4a

Typescript 4.9 rollup 2.79.1 (can't bump to rollup 3 until rollup-plugin-consts 1.1.1 is published to raise it's upper bound rollup dependency)

bump to rollup 3

4f01057

replace untmainained rollup-plugin-terser with @rollup/plugin-terser replace rollup-plugin-consts with a shim @rollup/plugin-virtual. They do the same thing, but consts is more opinionated about how it names its modules

Commit new package-lock.json

c3f11b4

lambdageek requested review from lewing and pavelsavara as code owners November 22, 2022 20:18

dotnet-issue-labeler bot added the area-Build-mono label Nov 22, 2022

ghost assigned lambdageek Nov 22, 2022

Create package-lock.json using npm v6 (from Emscripten)

d2463a5

And use the dnceng npm registry

Merge remote-tracking branch 'origin/main' into wasm-bump-devDependen…

d32cbca

…cies

update README with more details about upgrading NPM packages

5e4ad6e

Make markdownlint happy

fa868f7

pavelsavara approved these changes Nov 24, 2022

View reviewed changes

lambdageek merged commit 89cfbfd into dotnet:main Nov 24, 2022

maraf mentioned this pull request Dec 5, 2022

[wasm] Update generated typescript files #79222

Merged

ghost locked as resolved and limited conversation to collaborators Dec 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm] bump devDependencies to rollup 3 and TypeScript 4.9 #78726

[wasm] bump devDependencies to rollup 3 and TypeScript 4.9 #78726

lambdageek commented Nov 22, 2022 •

edited

Loading

lambdageek commented Nov 22, 2022

azure-pipelines bot commented Nov 22, 2022

lambdageek commented Nov 22, 2022

pavelsavara commented Nov 23, 2022 •

edited

Loading

pavelsavara commented Nov 23, 2022

pavelsavara commented Nov 23, 2022

maraf commented Nov 23, 2022

lambdageek commented Nov 23, 2022 •

edited

Loading

lambdageek commented Nov 23, 2022 •

edited

Loading

lambdageek commented Nov 23, 2022

lambdageek commented Nov 23, 2022

lambdageek commented Nov 23, 2022

radical commented Nov 23, 2022

lambdageek commented Nov 23, 2022

pavelsavara left a comment

[wasm] bump devDependencies to rollup 3 and TypeScript 4.9 #78726

[wasm] bump devDependencies to rollup 3 and TypeScript 4.9 #78726

Conversation

lambdageek commented Nov 22, 2022 • edited Loading

lambdageek commented Nov 22, 2022

azure-pipelines bot commented Nov 22, 2022

lambdageek commented Nov 22, 2022

pavelsavara commented Nov 23, 2022 • edited Loading

pavelsavara commented Nov 23, 2022

pavelsavara commented Nov 23, 2022

maraf commented Nov 23, 2022

lambdageek commented Nov 23, 2022 • edited Loading

lambdageek commented Nov 23, 2022 • edited Loading

lambdageek commented Nov 23, 2022

lambdageek commented Nov 23, 2022

lambdageek commented Nov 23, 2022

radical commented Nov 23, 2022

lambdageek commented Nov 23, 2022

pavelsavara left a comment

Choose a reason for hiding this comment

lambdageek commented Nov 22, 2022 •

edited

Loading

pavelsavara commented Nov 23, 2022 •

edited

Loading

lambdageek commented Nov 23, 2022 •

edited

Loading

lambdageek commented Nov 23, 2022 •

edited

Loading