Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] consider bumping devDependencies #78708

Closed
lambdageek opened this issue Nov 22, 2022 · 6 comments · Fixed by #78726
Closed

[wasm] consider bumping devDependencies #78708

lambdageek opened this issue Nov 22, 2022 · 6 comments · Fixed by #78726
Labels
arch-wasm WebAssembly architecture area-Build-mono

Comments

@lambdageek
Copy link
Member

We should consider bumping the devDependencies for our wasm runtime (in particular, rollup and TypeScript both have had major version releases):

$ npm outdated -D
Package                           Current  Wanted  Latest  Location                                       Depended by
@rollup/plugin-typescript           8.3.3   8.3.3   9.0.2  node_modules/@rollup/plugin-typescript         runtime
@typescript-eslint/eslint-plugin   5.30.7  5.30.7  5.44.0  node_modules/@typescript-eslint/eslint-plugin  runtime
@typescript-eslint/parser          5.30.7  5.30.7  5.44.0  node_modules/@typescript-eslint/parser         runtime
eslint                             8.20.0  8.20.0  8.28.0  node_modules/eslint                            runtime
fast-glob                          3.2.11  3.2.11  3.2.12  node_modules/fast-glob                         runtime
rollup                             2.77.0  2.77.0   3.4.0  node_modules/rollup                            runtime
rollup-plugin-dts                   4.2.2   4.2.2   5.0.0  node_modules/rollup-plugin-dts                 runtime
terser                             5.14.2  5.14.2  5.15.1  node_modules/terser                            runtime
tslib                               2.4.0   2.4.0   2.4.1  node_modules/tslib                             runtime
typescript                          4.7.4   4.7.4   4.9.3  node_modules/typescript                        runtime
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 22, 2022
@lambdageek lambdageek added arch-wasm WebAssembly architecture area-Build-mono and removed untriaged New issue has not been triaged by the area owner labels Nov 22, 2022
@ghost
Copy link

ghost commented Nov 22, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

We should consider bumping the devDependencies for our wasm runtime (in particular, rollup and TypeScript both have had major version releases):

$ npm outdated -D
Package                           Current  Wanted  Latest  Location                                       Depended by
@rollup/plugin-typescript           8.3.3   8.3.3   9.0.2  node_modules/@rollup/plugin-typescript         runtime
@typescript-eslint/eslint-plugin   5.30.7  5.30.7  5.44.0  node_modules/@typescript-eslint/eslint-plugin  runtime
@typescript-eslint/parser          5.30.7  5.30.7  5.44.0  node_modules/@typescript-eslint/parser         runtime
eslint                             8.20.0  8.20.0  8.28.0  node_modules/eslint                            runtime
fast-glob                          3.2.11  3.2.11  3.2.12  node_modules/fast-glob                         runtime
rollup                             2.77.0  2.77.0   3.4.0  node_modules/rollup                            runtime
rollup-plugin-dts                   4.2.2   4.2.2   5.0.0  node_modules/rollup-plugin-dts                 runtime
terser                             5.14.2  5.14.2  5.15.1  node_modules/terser                            runtime
tslib                               2.4.0   2.4.0   2.4.1  node_modules/tslib                             runtime
typescript                          4.7.4   4.7.4   4.9.3  node_modules/typescript                        runtime
Author: lambdageek
Assignees: -
Labels:

arch-wasm

Milestone: -

@lambdageek
Copy link
Member Author

Note that bumping rollup to version 3 will require rollup-plugin-consts 1.1.1 which hasn't been released yet.

@radical
Copy link
Member

radical commented Nov 22, 2022

cc @pavelsavara @maraf

@lambdageek
Copy link
Member Author

There's a bit more here:

rollup-plugin-terser is unmaintained and has been replaced by @rollup/plugin-terser

new TypeScript renamed some DOM typenames and requires a little bit of http.ts fixups

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 22, 2022
@lambdageek
Copy link
Member Author

I couldn't help myself and ended up making a PR

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 24, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants