Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-rc1] Add Arm64 PGO/IBC to Windows and Linux builds #74098

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 17, 2022

Backport of #73973 to release/7.0-rc1

/cc @DrewScoggins

Customer Impact

Currently we have no Arm64 optimization data whatsoever. This means we will have an impact on start up times, code quality and layout, working set and many other performance metrics

Testing

Current testing is just PR inner loop testing. We will know if there is a major performance impact in the next couple of days as we get more performance testing through the lab.

Risk

Low. In general, optimization data that does not make any major tooling changes is low risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 17, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #73973 to release/7.0-rc1

/cc @DrewScoggins

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@DrewScoggins
Copy link
Member

@davidwrighton

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. Once we get an additional code review and a green ci we can merge.

@carlossanlop
Copy link
Member

Approved and signed off.
CI failure is #73688
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 7ea346d into release/7.0-rc1 Aug 18, 2022
@carlossanlop carlossanlop deleted the backport/pr-73973-to-release/7.0-rc1 branch August 18, 2022 02:44
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants