Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arm64 PGO/IBC to Windows and Linux builds #73973

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Add Arm64 PGO/IBC to Windows and Linux builds #73973

merged 3 commits into from
Aug 17, 2022

Conversation

DrewScoggins
Copy link
Member

@DrewScoggins DrewScoggins commented Aug 15, 2022 •
edited
Loading

This commit adds the references for the new optimization nuget packages being generated for Arm64 on both OSes, as well as updating the PGO and IBC machinery in the build to consume the new packages.

@ghost ghost assigned DrewScoggins Aug 15, 2022
@ghost
Copy link

ghost commented Aug 15, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: DrewScoggins
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@danmoseley danmoseley closed this Aug 16, 2022
@danmoseley danmoseley reopened this Aug 16, 2022
davidwrighton
davidwrighton reviewed Aug 16, 2022
View reviewed changes
Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

@ghost
Copy link

ghost commented Aug 17, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This commit adds the references for the new optimization nuget packages being generated for Arm64 on both OSes, as well as updating the PGO and IBC machinery in the build to consume the new packages.

Author: DrewScoggins
Assignees: DrewScoggins
Labels:

area-Infrastructure-coreclr
Milestone: -

@DrewScoggins DrewScoggins merged commit 8027c80 into dotnet:main Aug 17, 2022
@DrewScoggins
Copy link
Member Author

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2878274552

@github-actions github-actions bot mentioned this pull request Aug 17, 2022
Merged
@EgorBo EgorBo mentioned this pull request Aug 23, 2022
Closed
@DrewScoggins
Copy link
Member Author

DrewScoggins commented Aug 25, 2022 •
edited by AndyAyersMS
Loading

We are seeing several big wins from the addition of this PGO data:

@AndyAyersMS AndyAyersMS mentioned this pull request Sep 12, 2022
Closed
@kunalspathak kunalspathak mentioned this pull request Sep 29, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidwrighton davidwrighton davidwrighton left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees

@DrewScoggins DrewScoggins

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DrewScoggins @stephentoub @davidwrighton @carlossanlop @danmoseley