Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperPMI] Added a new optional -compile argument #62217

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

SeanWoo
Copy link
Contributor

@SeanWoo SeanWoo commented Nov 30, 2021

Closes #62188

I added an optional -compile argument which is just directly thrown into superpmi.exe

Using:
With an index:
py .\superpmi.py asmdiffs-jit_name clrjit_universal_arm64_x64.dll --altjit -target_os Linux -target_arch arm64 -arch x64 -filter coreclr_tests -compile 1

With a range:
py .\superpmi.py replay -jit_name clrjit_universal_arm64_x64.dll --altjit -target_os Linux -target_arch arm64 -arch x64 -filter coreclr_tests -compile 1-200

Without -compile:
py .\superpmi.py asmdiffs-jit_name clrjit_universal_arm64_x64.dll --altjit -target_os Linux -target_arch arm64 -arch x64 -filter coreclr_tests

Do I need to make a check for compliance with the format or can I omit this point in the script?

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 30, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 30, 2021
@ghost
Copy link

ghost commented Nov 30, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on #62188

I added an optional -compile argument which is just directly thrown into superpmi.exe

Using:
With an index:
py .\superpmi.py asmdiffs-jit_name clrjit_universal_arm64_x64.dll --altjit -target_os Linux -target_arch arm64 -arch x64 -filter coreclr_tests -compile 1

With a range:
py .\superpmi.py replay -jit_name clrjit_universal_arm64_x64.dll --altjit -target_os Linux -target_arch arm64 -arch x64 -filter coreclr_tests -compile 1-200

Without -compile:
py .\superpmi.py asmdiffs-jit_name clrjit_universal_arm64_x64.dll --altjit -target_os Linux -target_arch arm64 -arch x64 -filter coreclr_tests

Do I need to make a check for compliance with the format or can I omit this point in the script?

Author: SeanWoo
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@SeanWoo
Copy link
Contributor Author

SeanWoo commented Nov 30, 2021

@jakobbotsch @BruceForstall please review

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; one suggestion.

Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
@SeanWoo SeanWoo requested a review from BruceForstall December 1, 2021 08:26
@BruceForstall BruceForstall merged commit c370c2d into dotnet:main Dec 1, 2021
@SeanWoo SeanWoo deleted the superpmi_compile_argument branch December 1, 2021 20:27
@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an argument to SuperPMI
3 participants