Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an argument to SuperPMI #62188

Closed
SeanWoo opened this issue Nov 30, 2021 · 4 comments · Fixed by #62217
Closed

Add an argument to SuperPMI #62188

SeanWoo opened this issue Nov 30, 2021 · 4 comments · Fixed by #62217
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@SeanWoo
Copy link
Contributor

SeanWoo commented Nov 30, 2021

I want to suggest adding an optional -c argument for superpmi.py asmdiffs

What will it give?

This will allow you to run certain tests, and not all at once, this is especially useful when a problem occurs in a certain test and it is easier to run it alone than to run it all at once. This would especially affect when collecting JitDump.

How will it work?

Adding a new argument -c to superpmi.py and we throw it into superpmi.exe when we run asmdiff, if -c is specified, then we remove the -p key (since this does not work if -c is specified)

I can implement it

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 30, 2021
@SingleAccretion SingleAccretion added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 30, 2021
@ghost
Copy link

ghost commented Nov 30, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

I want to suggest adding an optional -c argument for superpmi.py asmdiffs

What will it give?

This will allow you to run certain tests, and not all at once, this is especially useful when a problem occurs in a certain test and it is easier to run it alone than to run it all at once. This would especially affect when collecting JitDump.

How will it work?

Adding a new argument -c to superpmi.py and we throw it into superpmi.exe when we run asmdiff, if -c is specified, then we remove the -p key (since this does not work if -c is specified)

I can implement it

Author: SeanWoo
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged

Milestone: -

@JulieLeeMSFT
Copy link
Member

CC @dotnet/jit-contrib.
Thanks @SeanWoo for suggesting to implement it. We will review it once you submit a PR.

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Nov 30, 2021
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Nov 30, 2021
@BruceForstall
Copy link
Member

I've wanted to do this for a while; would be happy to see it. Without it, I've always just manually copy/pasted the superpmi.exe command line from the superpmi.log file generated by superpmi.py, and altered it as appropriate.

Note that you should add -c to both asmdiffs and replay for consistency.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Dec 1, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Dec 1, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants