Port InformationalVersion fix to Mono corelib #60614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#60572 for Mono's corelib.
akoeplinger
changed the title
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue Details#60572 for Mono's corelib.
|
Anipik
approved these changes
Oct 19, 2021
trylek
approved these changes
Oct 19, 2021
agocke
added a commit
to agocke/runtime
that referenced
this pull request
Oct 22, 2021
This reverts commit bab9826. This commit appears to be the cause of System.Drawing tests currently failing in main.
Anipik
pushed a commit
that referenced
this pull request
Nov 9, 2021
* Fix for #60532 In stable package mode we should be setting CoreLib informational version to the ProductVersion according to the discussion on the issue thread. I have verified locally that this fixes the processinfo2 test for me that was previously failing in the StabilizePackageVersion mode. Please let me know how to proceed with the fix, whether you want me to just merge it into dotnet/runtime main, whether I should pursue its backport into 6.0 release and / or whether Matt considers cherry-picking my change to his stabilization PR. Thanks Tomas * Port InformationVersion fix to Mono corelib (#60614) #60572 for Mono's corelib. Co-authored-by: Tomas Rylek <trylek@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60572 for Mono's corelib.