Fix for #60532 #60572
Fix for #60532 #60572
Conversation
In stable package mode we should be setting CoreLib informational version to the ProductVersion according to the discussion on the issue thread. I have verified locally that this fixes the processinfo2 test for me that was previously failing in the StabilizePackageVersion mode. Please let me know how to proceed with the fix, whether you want me to just merge it into dotnet/runtime main, whether I should pursue its backport into 6.0 release and / or whether Matt considers cherry-picking my change to his stabilization PR. Thanks Tomas
|
For main we might also want to make sure that |
|
OK, merging this in with the understanding that the related scripts merit additional cleanup but that's not blocked on "day D". |
dotnet#60572 for Mono's corelib.
#60572 for Mono's corelib.
|
@jeffschwMSFT @danmoseley will be the right person to make a decision on this. |
|
The impact is that, without the fix, the shipping System.Private.CoreLib would be marked with an internal informational version "6.0.0-dev" instead of the expected "6.0.0". According to MSIL documentation runtime itself should never look at this value, it's just an informational text as the name suggests, we only hit this issue in a test that happens to compare it to coreclr.dll version information (which is correctly set to "6.0.0"). It was most likely the same in .NET 5 and frankly speaking I don't think anyone noticed in the last year or so. |
|
I think we should take this. @trylek can you create a backport? |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1423935628 |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1423971588 |
* Fix for #60532 In stable package mode we should be setting CoreLib informational version to the ProductVersion according to the discussion on the issue thread. I have verified locally that this fixes the processinfo2 test for me that was previously failing in the StabilizePackageVersion mode. Please let me know how to proceed with the fix, whether you want me to just merge it into dotnet/runtime main, whether I should pursue its backport into 6.0 release and / or whether Matt considers cherry-picking my change to his stabilization PR. Thanks Tomas * Port InformationVersion fix to Mono corelib (#60614) #60572 for Mono's corelib. Co-authored-by: Tomas Rylek <trylek@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
ghost
locked as resolved and limited conversation to collaborators
In stable package mode we should be setting CoreLib informational
version to the ProductVersion according to the discussion on the
issue thread. I have verified locally that this fixes the processinfo2
test for me that was previously failing in the StabilizePackageVersion
mode. Please let me know how to proceed with the fix, whether you
want me to just merge it into dotnet/runtime main, whether I should
pursue its backport into 6.0 release and / or whether Matt considers
cherry-picking my change to his stabilization PR.
Thanks
Tomas
Fixes #60532
/cc @dotnet/runtime-infrastructure