[release/5.0-preview8] Wasm ICU #39739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR overhauls runtime startup/asset loading and adds support for ICU integration.
The mono-config.js format is reworked and simplified, with new functionality added:
Individual assets can be loaded from one or more remote sources with configurable fallback behavior
In addition to the existing support for loading assemblies, you can now pre-load arbitrary files into the native heap or into emscripten's virtual file system. VFS support previously only existed in runtime-test.js but now is available to any consumer of dotnet.js.
Assets can have a virtual path set so that their application-facing path does not necessarily have to match their path on the server.
One or more ICU data archives can be added to the assets list and will be automatically loaded and used to enable ICU-based globalization support.
Many configuration knobs that previously required API calls can now be set declaratively in the configuration file (environment variables, etc.)
WasmAppBuilder is updated to add ICUDataFiles and RemoteSources parameters that can be used to add the associated information to the config file declaratively from a msbuild project.
Various adjustments are made to existing tests and test cases so that they will pass with the addition of ICU integration.
Co-authored-by: EgorBo <egorbo@gmail.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
* Add data archive loading to the generic loading logic
lewing
force-pushed
the
wasm-icu-preview8
branch
from
2a46beb
to
8f549f1
Compare
lewing
requested review from
alexischr,
CoffeeFlux,
lambdageek,
marek-safar,
thaystg and
vargaz
as code owners
akoeplinger
approved these changes
Jul 21, 2020
|
The 1 wasm test failure is #39473 |
EgorBo
approved these changes
Jul 22, 2020
|
@lewing you need to add the servicing template to the issue description. This will help the tactics in evaluating the effect & scope of the change. eg #39657 After adding the description please mark the issue with servicing-consider label. The change will be discussed in the next meeting. if you want an immediate answer you can send an email to tactics team with the servicing template. |
|
Approved offline by @SteveCarrollMSFT |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include Globalization in the preview8 wasm runtime.
A direct port of the changes in master related to icu.
Description
Adds a static build of dotnet/icu to the wasm runtime and some additional support javascript.
Customer Impact
Enables full globalization rather than forced invariant mode in the WASM runtime. Supports proper string collation and the included locales.
Risk
Low, Blazor is the consumer here and would like this change in the preview.