Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ICU in blazor #24174

Closed
lewing opened this issue Jul 21, 2020 · 5 comments · Fixed by #24773
Closed

Enable ICU in blazor #24174

lewing opened this issue Jul 21, 2020 · 5 comments · Fixed by #24773
Assignees
@pranavkm
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Milestone
5.0.0-preview8

Comments

@lewing
Copy link
Member

lewing commented Jul 21, 2020 •
edited
Loading

Since the blazor platform code calls directly into the runtime rather than using the normal initialization code it doesn't have the logic to load the icudt.dat file into the runtime that is required to enable icu. It will need to copy icudt.dat from the runtime pack and insert it into memory using offset = this.mono_wasm_load_bytes_into_heap (bytes) and this.mono_wasm_load_icu_data (offset) and only do the logic in #24163 if that file doesn't exist
@lewing lewing added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Jul 21, 2020
@lewing
Copy link
Member Author

lewing commented Jul 21, 2020

cc @pranavkm @SteveSandersonMS

@pranavkm pranavkm self-assigned this Jul 21, 2020
@pranavkm
Copy link
Contributor

Thanks @lewing. Is this available in the p8 branch?

@lewing
Copy link
Member Author

lewing commented Jul 21, 2020

not yet, merge to p8 pr soon

@lewing
Copy link
Member Author

lewing commented Jul 21, 2020

dotnet/runtime#39739

@mkArtakMSFT mkArtakMSFT modified the milestones: 5.0.0-rc1, 5.0.0-preview8 Jul 22, 2020
@mkArtakMSFT mkArtakMSFT added the blocked The work on this issue is blocked due to some dependency label Jul 22, 2020
@lewing
Copy link
Member Author

lewing commented Jul 22, 2020

@pranavkm @mkArtakMSFT merged in preview8 now

@mkArtakMSFT mkArtakMSFT mentioned this issue Jul 27, 2020
Closed
@pranavkm pranavkm removed the blocked The work on this issue is blocked due to some dependency label Jul 28, 2020
pranavkm pushed a commit that referenced this issue Aug 11, 2020
@pranavkm
Merged PR 9371: Revive support for globalization and localization in …
c3df503 
…Blazor WASM

Revive support for globalization and localization in Blazor WASM

* Load icu and timezone data files
* Unskip tests

Fixes #24174
Fixes #22975
Fixes #23260
@pranavkm pranavkm mentioned this issue Aug 11, 2020
Merged
pranavkm pushed a commit that referenced this issue Aug 11, 2020
@pranavkm
Merged PR 9371: Revive support for globalization and localization in …
3818ef0 
…Blazor WASM

Revive support for globalization and localization in Blazor WASM

* Load icu and timezone data files
* Unskip tests

Fixes #24174
Fixes #22975
Fixes #23260
pranavkm pushed a commit that referenced this issue Aug 17, 2020
@pranavkm
Merged PR 9371: Revive support for globalization and localization in …
4e57d1b 
…Blazor WASM

Revive support for globalization and localization in Blazor WASM

* Load icu and timezone data files
* Unskip tests

Fixes #24174
Fixes #22975
Fixes #23260
pranavkm added a commit that referenced this issue Aug 18, 2020
@pranavkm
Merged PR 9371: Revive support for globalization and localization in …
2ad1b6d 
…Blazor WASM (#24773)

* Merged PR 9371: Revive support for globalization and localization in Blazor WASM

Revive support for globalization and localization in Blazor WASM

* Load icu and timezone data files
* Unskip tests

Fixes #24174
Fixes #22975
Fixes #23260
wtgodbe pushed a commit that referenced this issue Aug 26, 2020
Merged PR 9371: Revive support for globalization and localization in …
3e7a106 
…Blazor WASM

Revive support for globalization and localization in Blazor WASM

* Load icu and timezone data files
* Unskip tests

Fixes #24174
Fixes #22975
Fixes #23260
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2020
dougbu pushed a commit to dougbu/razor-compiler that referenced this issue Nov 17, 2021
Merged PR 9371: Revive support for globalization and localization in …
0a7ab2f 
…Blazor WASM

Revive support for globalization and localization in Blazor WASM

* Load icu and timezone data files
* Unskip tests

Fixes dotnet/aspnetcore#24174
Fixes dotnet/aspnetcore#22975
Fixes dotnet/aspnetcore#23260

Commit migrated from dotnet/aspnetcore@3e7a10649154
dougbu pushed a commit to dougbu/razor-compiler that referenced this issue Nov 17, 2021
@pranavkm
Merged PR 9371: Revive support for globalization and localization in …
d0479ed 
…Blazor WASM

Revive support for globalization and localization in Blazor WASM

* Load icu and timezone data files
* Unskip tests

Fixes dotnet/aspnetcore#24174
Fixes dotnet/aspnetcore#22975
Fixes dotnet/aspnetcore#23260

Commit migrated from dotnet/aspnetcore@4e57d1b041d1
3dots pushed a commit to 3dots/aspnetcore-Web.JS that referenced this issue Feb 19, 2024
Merged PR 9371: Revive support for globalization and localization in …
a8a2f94 
…Blazor WASM

Revive support for globalization and localization in Blazor WASM

* Load icu and timezone data files
* Unskip tests

Fixes dotnet/aspnetcore#24174
Fixes dotnet/aspnetcore#22975
Fixes dotnet/aspnetcore#23260
3dots pushed a commit to 3dots/aspnetcore-Web.JS that referenced this issue Feb 19, 2024
@pranavkm
Merged PR 9371: Revive support for globalization and localization in …
7707b8d 
…Blazor WASM

Revive support for globalization and localization in Blazor WASM

* Load icu and timezone data files
* Unskip tests

Fixes dotnet/aspnetcore#24174
Fixes dotnet/aspnetcore#22975
Fixes dotnet/aspnetcore#23260
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Milestone
5.0.0-preview8
Development

Successfully merging a pull request may close this issue.

Merged PR 9371: Revive support for globalization and localization in Blazor WASM dotnet/aspnetcore
3 participants
@lewing @pranavkm @mkArtakMSFT