-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IDynamicInterfaceCastable interface #37042
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
f3d9948
to
9cd3126
Compare
Does Lines 345 to 349 in 00c0328
|
Yes - that is changed: https://github.com/dotnet/runtime/pull/37042/files#diff-62699d7b49d1d40e84362b31c5df4db4R343 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/coreclr/src/System.Private.CoreLib/src/System/Runtime/CompilerServices/ICastableHelpers.cs
Outdated
Show resolved
Hide resolved
src/coreclr/src/System.Private.CoreLib/src/System/Runtime/CompilerServices/ICastableHelpers.cs
Outdated
Show resolved
Hide resolved
src/coreclr/src/System.Private.CoreLib/src/System/Runtime/CompilerServices/ICastableHelpers.cs
Outdated
Show resolved
Hide resolved
d18cec2
to
e03c063
Compare
e03c063
to
2242b6c
Compare
d21e9ed
to
c803601
Compare
src/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Approved API: #36654
IDynamicInterfaceCastable
andDynamicInterfaceCastableImplementation
IDynamicInterfaceCastable.GetInterfaceImplementation
is called as a fallback for isinst, castclass, and interface dispatch when casting in the normal way fails.cc @AaronRobinsonMSFT @jkoritzinsky