Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
elinor-fung committed Jun 3, 2020
1 parent 802cdaa commit c803601
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/coreclr/src/vm/jitinterface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4501,7 +4501,7 @@ TypeCompareState CEEInfo::compareTypesForCast(
else
#endif // FEATURE_COMINTEROP

// If casting from ICastable, don't try to optimize
// If casting from ICastable or IDynamicInterfaceCastable, don't try to optimize
if (fromHnd.GetMethodTable()->IsICastable() || fromHnd.GetMethodTable()->IsIDynamicInterfaceCastable())
{
result = TypeCompareState::May;
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/vm/methodtable.h
Original file line number Diff line number Diff line change
Expand Up @@ -3601,7 +3601,7 @@ public :

enum_flag_HasFinalizer = 0x00100000, // instances require finalization

enum_flag_IDynamicInterfaceCastable = 0x00200000, // class implements IDynamicInterfaceCastable interface
enum_flag_IDynamicInterfaceCastable = 0x00200000, // class implements IDynamicInterfaceCastable interface

enum_flag_ICastable = 0x00400000, // class implements ICastable interface

Expand Down
1 change: 0 additions & 1 deletion src/coreclr/src/vm/prestub.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1907,7 +1907,6 @@ extern "C" PCODE STDCALL PreStubWorker(TransitionBlock* pTransitionBlock, Method
{
pDispatchingMT = curobj->GetMethodTable();


if (pDispatchingMT->IsICastable() || pDispatchingMT->IsIDynamicInterfaceCastable())
{
MethodTable* pMDMT = pMD->GetMethodTable();
Expand Down

0 comments on commit c803601

Please sign in to comment.