Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entry point helper scripts #33756

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Remove entry point helper scripts #33756

merged 4 commits into from
Apr 6, 2020

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 19, 2020

NO MERGE, part of batched rollout cycle: #33821

The entry point helper scripts were useful during the consolidation of the repositories. This work is mostly done and the build.cmd/sh script should be used going forward to promote a single entrypoint to build the repository and being able to build multiple subsetcategories at once.

TODO before merging:

  • Create/update an announcement issue
  • Announce in gitter channel

cc @stephentoub @jkotas @danmosemsft @steveisok @dotnet/runtime-infrastructure

@ViktorHofer ViktorHofer added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-Infrastructure labels Mar 19, 2020
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once it passes the CI.

@danmoseley
Copy link
Member

danmoseley commented Mar 19, 2020

This is the right direction, but I thought we were rolling changes that break developer workflow into batches to avoid contributor fatigue.

Would it cause expense to just hold this for 2 or 3 weeks into a batch of workflow breaks in say mid April (I made that up)?

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Mar 19, 2020

sure, I applied the no merge label anyway.

@ViktorHofer
Copy link
Member Author

This will break source-indexer, therefore I'm updating it pro-actively: https://github.com/dotnet/source-indexer/blob/5210eb17a3b615c1c4aa57425f35271eaa340066/src/index/repositories.props#L4-L33.

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my 2 comments, LGTM.

@ViktorHofer
Copy link
Member Author

Would it cause expense to just hold this for 2 or 3 weeks into a batch of workflow breaks in say mid April (I made that up)?

@danmosemsft Created #33821 to track the rollout of this change.

The entry point helper scripts were useful during the consolidation of
the repositories. This work is mostly done and the build.cmd/sh script
should be used, going forward.
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 6, 2020

Rebased and queued official build: https://dnceng.visualstudio.com/internal/_build/results?buildId=590038

@ViktorHofer ViktorHofer merged commit 62112b0 into master Apr 6, 2020
@ViktorHofer ViktorHofer deleted the HelperScriptsRemoval branch April 6, 2020 13:38
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants