Update dotnet/runtime build invocation #45
Conversation
dotnet/runtime will remove the build helper scripts (coreclr.cmd, libraries.cmd, etc.) soon. Proactively updating the invocation here to prevent a break in the source-indexer.
| @@ -28,7 +28,7 @@ | |||
| /* | |||
| </SparseCheckout> | |||
| <PrepareCommand> | |||
| src\coreclr\build.cmd -skiptests -skipnative -linuxmscorlib && libraries.cmd /p:BuildNative=false /p:BuildPackages=false -binarylog -os Linux | |||
| build.cmd -subsetcategory coreclr-libraries -subset corelib-all /p:BuildNative=false /p:BuildPackages=false -binarylog -os Linux | |||
There was a problem hiding this comment.
Will this build both corelib and the libraries? Is this going to build every version of corelib? It should only build the linux mscorlib, because we use existence of the output file to determine which version of a project to index.
There was a problem hiding this comment.
Because of the -os parameter at the end this builds Linux (only).
Will this build both corelib and the libraries?
This builds CoreLib from coreclr and libraries managed code.
There was a problem hiding this comment.
Can we test the changes somehow? :)
There was a problem hiding this comment.
You can just run msbuild build.proj locally. It will take a long time, but will produce the index locally that you can run.
There was a problem hiding this comment.
I'm relatively certain this is good as is. Let's merge and I'll monitor the build.
dotnet/runtime will remove the build helper scripts (coreclr.cmd, libraries.cmd, etc.) soon. Proactively updating the invocation here to prevent a break in the source-indexer.